chore (distro/wildfly*): use different type for PROPERTIES node in st…

[langfr]

…andalone.xml

Related to CAM-7779.

[sdorokhova]

Hi Frank,

thank you for your pull request! The thing that I don't like about proposed changes is that all current Camunda/Wildfly users will need to update there standalone.xml files when upgrading to Camunda 7.8, even though they don't need any "real" changes there. Did I get it right? Is it supposed to be like this?

Looking into the problem, have you understood what was changed in Wildfly 11, that broke the parser? Did they changed something in SimpleMapAttributeDefinition? Can we may be find another workaround to this problem?

Best regards,
Svetlana

[langfr]

Hello Svetlana,
yes, with this PR this would be the case. Users will anyways have to stop wildfly, replace existing camunda and third-party libs from the modules folder and put the new ones there.
So yes, it is an additional effort, but no big thing.

I did not dive into the details which change in wildfly-core brought this marshalling change.
I even cannot say which version exactly. The problem was there right from the beginning when I started to try current Camunda master inside Wildfly11-Alpha1. But not Wildfly 11 but Wildfly-Core 3 is the relevant piece of software.

A couple of days ago a new wildfly-core version (Beta 24) introduced new problems. Now Camunda's CustomMarshaller does not work anymore and throws exceptions.
Method getValueTypes was called with an instance of org.camunda.bpm.container.impl.jboss.util.FixedObjectTypeAttributeDefinition and clazz as
org.jboss.as.controller.ObjectTypeAttributeDefinition.
Now instance is of different type suddenly. Don't ask me why.

In my camunda for I created a wildfly11 distro. See https://github.com/langfr/camunda-bpm-platform/commits/master.
Cloning distro/wildfly and changing the artifactId's
12c12
< camunda-wildfly

camunda-wildfly11
The only mandatory change to the sources was to add the value attribute to the propertyType in foxEngineSubsystem_1_1.xsd:
<xs:attribute name="value" use="required"/>
Added some wildfly11 related properties to parent/pom.xml:
<version.wildfly11>11.0.0.Alpha1</version.wildfly11>
<version.wildfly11.core>3.0.0.Beta23</version.wildfly11.core>
<version.java.wildfly11>1.8</version.java.wildfly11>
This distro builds fine with these settings. If you change version.wildfly11.core to Beta24 or later (current is Beta26), then tests fail.

Regards, Frank

[sdorokhova]

Hello Frank,

thank you for your investigation and fixes you're proposing! In general it's fine to change format of standalone.xml , but your last comment about the new problem clarifies the whole picture. I could not find the current Wildfly roadmap, but looking at the release history for v. 10, I suppose some more 11.0.0.AlphaX versions are coming, which can require more changes. (I looked here - Table 1. WildFly 10 Releases)

Therefore I would propose to apply all the required changes at once after Wildfly 11 and Wildfly Core 3 are stabilized more or less.

We would appreciate you posting a new pull request when you have a feeling that it's finalized more or less.

Best regards,
Svetlana