-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(engine): Skip ByteArray Deletion when Updating Var #4313
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
76f1698
to
a4320fb
Compare
d68db41
to
ff613da
Compare
✔ The build has already passed with |
@tasso94 i can't assign this PR to your as a reviewer. Not sure why. |
related to SUPPORT-21721
964c9d4
to
6ed2826
Compare
Notes for the Reviewer
Note: The other two tests for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Description: During Set Variable and Read Variable operations, the following partial ORM operations can occur in a problematic sequence:
Solution: Instead of deleting an updating the byte array value, during the update, the deletion is simply skipped.
The fix was verified with the customer.
The above behaviour introduces leftover byte-array state on type change. Thus, only during a type change, the byte-array is deleted.
Unit-tests: This commit introduces unit tests that verify the correct state of the variables on type change.
Limitations Accepted: The issue could not be reproduced with a unit test. However, this is accepted since the fix follows a common theme for value update across all the project and is not expected to produce a regression. Moreover, the mere reproduction of the problem using private calls doesn't give any extra value.
Co-authored-by: tasso94, petros.savvidis
Related-to: #4324, https://jira.camunda.com/browse/SUPPORT-21494