Skip to content
This repository has been archived by the owner on Dec 12, 2019. It is now read-only.

CAM-11160: Allow asynchronous on multi-instance characteristics #25

Closed
wants to merge 2 commits into from

Conversation

tiesebarrell
Copy link

@tiesebarrell tiesebarrell commented Nov 29, 2019

CAM-11160

This feature allows to configure the asynchronous behaviour of element activities of a multi-instance activity from the fluent builder API, in addition to the existing feature to set the asynchronous behaviour for the whole multi-instance body.

@mboskamp mboskamp changed the title feat(model): allow asynchronous on multi-instance characteristics CAM-11160: Allow asynchronous on multi-instance characteristics Dec 5, 2019
@mboskamp
Copy link
Member

mboskamp commented Dec 5, 2019

Hi @tiesebarrell,

thank you for your contribution. I opened CAM-11160 to track the PR in our issue tracker.
Somebody of the development team will have a look into your changes and will come back to you.

Best,
Miklas

Copy link
Member

@ThorbenLindhauer ThorbenLindhauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Tiese,

Thanks for the contribution, the code looks fine. Could you please add a test case to ProcessBuilderTest though? E.g. by extending this test case: https://github.com/camunda/camunda-bpmn-model/blob/7.12.0/src/test/java/org/camunda/bpm/model/bpmn/builder/ProcessBuilderTest.java#L2051-L2079

Cheers,
Thorben

* Added test cases for multi-instance elements;
@tiesebarrell
Copy link
Author

Could you please add a test case to ProcessBuilderTest though? E.g. by extending this test case: https://github.com/camunda/camunda-bpmn-model/blob/7.12.0/src/test/java/org/camunda/bpm/model/bpmn/builder/ProcessBuilderTest.java#L2051-L2079

  • Added two test cases.

ThorbenLindhauer added a commit to camunda/camunda-bpm-platform that referenced this pull request Dec 12, 2019
@ThorbenLindhauer
Copy link
Member

Thanks for providing the test. In the last days we have merged the model API repositories into camunda-bpm-platform, so I have applied your contribution there: camunda/camunda-bpm-platform@7fb67f3

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants