-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
archive(8.1) isolation: automated steps #3755
archive(8.1) isolation: automated steps #3755
Conversation
79d71a5
to
ff23e39
Compare
I was second-guessing my approval because the build process was also modified in the linked reference PR, but I don't think that's necessary here. Can you confirm? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@akeller I commented inline with all the reasons that the deployment workflows are modified. Let me know if any of it doesn't make sense!
@@ -3,14 +3,7 @@ name: publish-prod | |||
on: | |||
push: | |||
tags: | |||
- "[0-9]+.[0-9]+.[0-9]+" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
publish-prod is modified so that it only runs for 8.1.x tags. This branch, unsupported/8.1
, will only contain the 8.1 site. We want to be able to deploy it to production, which we will continue to be able to do by adding new 8.1.x tags.
@@ -46,7 +39,7 @@ jobs: | |||
with: | |||
switches: -avzr --delete | |||
path: build/ | |||
remote_path: ${{ secrets.AWS_PROD_PUBLISH_PATH }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this drops it in the unsupported.docs.camunda.io
domain instead of docs.camunda.io
.
@@ -3,7 +3,7 @@ name: publish-stage | |||
on: | |||
push: | |||
branches: | |||
- "main" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This branch is going to be deployed to stage.unsupported.docs.camunda.io/8.1
, and we only want to deploy this branch.
@@ -21,7 +21,7 @@ jobs: | |||
- name: Install Dependencies | |||
run: npm ci | |||
- name: Update URL | |||
run: 'sed -i ''s!url: "https://docs.camunda.io"!url: "https://stage.docs.camunda.io"!g'' docusaurus.config.js' | |||
run: 'sed -i ''s!url: "https://unsupported.docs.camunda.io"!url: "https://stage.unsupported.docs.camunda.io"!g'' docusaurus.config.js' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The docusaurus config contains references to the unsupported URL, so this step needs to account for that.
@@ -43,7 +43,7 @@ jobs: | |||
with: | |||
switches: -avzr --delete | |||
path: build/ | |||
remote_path: ${{ secrets.AWS_STAGE_PUBLISH_PATH }} | |||
remote_path: ${{ secrets.AWS_STAGE_PUBLISH_PATH_UNSUPPORTED }}/8.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
staging site for this branch is deployed to stage.unsupported.docs.camunda.io/8.1
.
@@ -3,12 +3,12 @@ | |||
FROM httpd:alpine | |||
|
|||
RUN rm -r /usr/local/apache2/htdocs/* | |||
COPY /build /usr/local/apache2/htdocs/ | |||
COPY /build /usr/local/apache2/htdocs/8.1/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This Dockerfile is for local development. Running the site within an 8.1 folder allows us to not have to make changes to the docusaurus configuration, which is expecting the site to be deployed within an 8.1 folder.
As discussed over Slack, the issue is not the deployment workflows, but This happened because the script to delete all that stuff is looking for the line to build the docs, which specifies the heap size.......which we updated recently, thus causing the script to not find what it was looking for. Updating & adding that removal to this PR! |
I'll update the associated script in a separate PR, so that it can target |
Odd that it didn't prompt me to approve again, but you are good to merge when ready! |
Maybe GitHub doesn't care as much because it's not merging into |
Description
Part of #3731.
Note: this PR will be merged into the
unsupported/8.1
branch. It will never make it into main.Note: this PR will not go green. There are manual cleanup steps coming in a future PR that will make this branch green.
Continues the process of archival/isolation for version 8.1. Includes the following steps, which a computer did for me:
See #2796 for a similar PR in a previous archived version, if that's helpful for comparison purposes during review.
Description
When should this change go live?
hold
label or convert to draft PR)PR Checklist
/versioned_docs
directory./docs
directory (aka/next/
).