fix: update archival scripts #3759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepopowitz
added
kind/bug
pepopowitz
commented
May 2, 2024
Comment on lines
-3
to
-4
| # 1. build-docs: remove everything after the line `NODE_OPTIONS: --max_old_space_size=4096`. | ||
| sed -i '' '/NODE_OPTIONS: --max_old_space_size=4096/q' .github/workflows/build-docs.yaml |
There was a problem hiding this comment.
This broke because I updated the heap size in build-docs.yaml recently. Here I've removed the heap size number entirely, in case we need to bump again in the future.
| @@ -32,5 +32,5 @@ sed -i '' "s/optimize\/$ARCHIVED_OPTIMIZE_VERSION\//optimize\//g" versioned_side | |||
| # remove hard-coded versions from optimize docs sidebar configuration | |||
| sed -i '' "s/docs\/$ARCHIVED_VERSION\//docs\//g" optimize_versioned_sidebars/version-$ARCHIVED_OPTIMIZE_VERSION-sidebars.json | |||
|
|
|||
| git add docusaurus.config.js src/mdx versioned_sidebars optimize_versioned_sidebars | |||
There was a problem hiding this comment.
I noticed this in time to fix it in #3755, but this script was not including one of the changed files in the commit.
akeller
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the scripts for archiving versions, to fix a couple things that were being dropped during the archival.
Also updates the versions in the archival script, which is unnecessary, but is also a good hint for the next time we archive.
When should this change go live?
holdlabel or convert to draft PR)PR Checklist
/versioned_docsdirectory./docsdirectory (aka/next/).