Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DMN Properties Panel: Input blurred on commandStack.changed #1100

Closed
philippfromme opened this issue Jan 15, 2019 · 2 comments
Closed

DMN Properties Panel: Input blurred on commandStack.changed #1100

philippfromme opened this issue Jan 15, 2019 · 2 comments
Assignees
@pinussilvestrus
Labels
bug Something isn't working
Milestone
M26

Comments

@philippfromme
Copy link
Contributor

2019-01-15_14-30-45

Reproduce

  1. Open DMN tab
  2. Edit property through properties panel

Expected Behavior

  1. Input stays focussed

Actual Behavior

  1. Input is blurred
@philippfromme philippfromme added the bug Something isn't working label Jan 15, 2019
@philippfromme philippfromme added this to the M26 milestone Jan 15, 2019
@philippfromme philippfromme mentioned this issue Jan 15, 2019
Closed
58 tasks
@pinussilvestrus pinussilvestrus added ready Ready to be worked on in progress Currently worked on and removed ready Ready to be worked on labels Jan 16, 2019
@pinussilvestrus pinussilvestrus self-assigned this Jan 16, 2019
@pinussilvestrus
Copy link
Contributor

Seems to be caused by reattaching the properties panel on every view changed event: https://github.com/camunda/camunda-modeler/blob/next/client/src/app/tabs/dmn/DmnEditor.js#L214

@pinussilvestrus pinussilvestrus mentioned this issue Jan 16, 2019
Closed
pinussilvestrus pushed a commit that referenced this issue Jan 16, 2019
fix(DmnEditor): prevent reattaching properties panel on every change
aa724f7 
Closes #1100
pinussilvestrus pushed a commit that referenced this issue Jan 16, 2019
fix(client/dmn-editor): prevent reattaching properties panel on every…
fa31eec 
… change

Closes #1100
pinussilvestrus pushed a commit that referenced this issue Jan 16, 2019
fix(client/dmn-editor): prevent reattaching properties panel
11443ac 
Closes #1100
@pinussilvestrus pinussilvestrus mentioned this issue Jan 16, 2019
Merged
@ghost ghost added needs review Review pending and removed in progress Currently worked on labels Jan 16, 2019
merge-me bot pushed a commit that referenced this issue Jan 16, 2019
@merge-me
fix(client/dmn-editor): prevent reattaching properties panel
615c1b5 
Closes #1100
@barmac
Copy link
Contributor

barmac commented Jan 16, 2019

Closed via #1113

@barmac barmac closed this as completed Jan 16, 2019
@ghost ghost removed the needs review Review pending label Jan 16, 2019
@philippfromme philippfromme mentioned this issue Jan 17, 2019
Open
barmac pushed a commit that referenced this issue Jan 17, 2019
@barmac
fix(client/dmn-editor): prevent reattaching properties panel
970b6f2 
Closes #1100
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pinussilvestrus pinussilvestrus

Labels
bug Something isn't working
Projects
None yet
Milestone
M26
Development

No branches or pull requests
3 participants
@philippfromme @pinussilvestrus @barmac