Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ambigious CTRL + T shortcut #2312

Closed
MaxTru opened this issue Jun 16, 2021 · 2 comments · Fixed by #2321
Closed

Remove ambigious CTRL + T shortcut #2312

MaxTru opened this issue Jun 16, 2021 · 2 comments · Fixed by #2321
Assignees
@MaxTru
Labels
enhancement New feature or request ux
Milestone
M48

Comments

@MaxTru
Copy link
Contributor

MaxTru commented Jun 16, 2021

Describe the Task

Remove ambigious CTRL + T shortcut.

The Camunda Modeler supports (as-is) four diagram types: BPMN-Cloud, BPMN-Platform, Form, DMN.

The CTRL + T shortcut will create a new BPMN-Platform tab.

This behavior is clearly ambigious (user would not immediately notice she created a Platform diagram, even though she works in a Cloud context). We also retrieved feedback regarding this (see #2293, #2283).

This issue aims at removing the CTRL + T shortcut as a quick fix.

Mid-term and long-term an improved concepts (including the + button) shall be implemented to allow the user to quickly create new tabs (also see #2309 ).

Alternatives

  • Keep the CTRL+T shortcut, but open the file select menue
    • Keep the CTRL+T shortcut, but open same file type as currently opened
@MaxTru MaxTru added enhancement New feature or request ux labels Jun 16, 2021
@MaxTru MaxTru added the ready Ready to be worked on label Jun 16, 2021 — with bpmn-io-tasks
@MaxTru
Copy link
Contributor Author

MaxTru commented Jun 16, 2021

Moving to ready, since this should be fixed in line with #2293

@MaxTru MaxTru added this to the M48 milestone Jun 16, 2021
@MaxTru MaxTru mentioned this issue Jun 22, 2021
Open
MaxTru added a commit that referenced this issue Jun 22, 2021
@MaxTru
chore(TabsProvider): remove ambigious CTRL+T hotkey
1a064ae 
Closes #2312

* Ambiguity results from the fact that we now support CamundaCloud and
  CamundaPlatform
* However, the feature to have a shortcut creation of a new tab, shall
  be re-added soon. Also see #2309
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed ready Ready to be worked on labels Jun 22, 2021
@MaxTru MaxTru mentioned this issue Jun 22, 2021
Merged
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Jun 22, 2021
@MaxTru
Copy link
Contributor Author

MaxTru commented Jun 22, 2021

Closed with #2321

@MaxTru MaxTru closed this as completed Jun 22, 2021
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jun 22, 2021
nikku pushed a commit that referenced this issue Jul 6, 2021
@MaxTru @merge-me
chore(TabsProvider): remove ambigious CTRL+T hotkey
15f0cc8 
Closes #2312

* Ambiguity results from the fact that we now support CamundaCloud and
  CamundaPlatform
* However, the feature to have a shortcut creation of a new tab, shall
  be re-added soon. Also see #2309
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MaxTru MaxTru

Labels
enhancement New feature or request ux
Projects
None yet
Milestone
M48
Development

Successfully merging a pull request may close this issue.

chore(TabsProvider): remove ambigious CTRL+T hotkey camunda/camunda-modeler
1 participant
@MaxTru