-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove +
button
#2293
Comments
The plus button was part of the unified modeler concept but we did not find the time to implement the solution. I'm fine with removing it (at least as an intermediate fix) since this causes trouble now. |
I frequently use the Please consider keeping the When the welcome page is shown, the button can be hidden because there is already a selection for the file type. Once a user selected a file type for the first diagram or has opened an existing file, the most likely next action is to create more of the same. |
Another option for power users if you insist on removing the |
This could easily be done and I personally also favor this approach - @nikku @andreasgeier was this dicussed, is there any reason why removing the |
We should not do that. We also have to consider a scenario where multiple tabs are opened. Then it becomes hard to predict what file will be created. Even harder if we consider the scenario that at start up the Modeler re-opens multiple tabs from the last session. The solution would not only violate the (UX) rule of not being predictable but also that the same button should always behave the same, meaning a plus should not create a BPMN this time and a DMN next time or (as an example from the prop panel) an error now and a message later. |
I see what you mean, yet playing around with it, I do not think it is a problem. As you can see in the screencast. I dont feel it is surprising or unpredictable due to two reasons:
If you want to try it yourself, test with this artifact: What do you think? In the end I am not super opinionated and would also be okay with removing the button. I would just like to have a second validation now that we have this working prototype anyhow to ensure we are doing the right thing. |
@falko @MaxTru Any change in the plus button behavior is a breaking one and needs to be properly communicated to the user. Thus my proposal to simply remove it and re-consider introducing it some day in the future (or never). If we want a create a new document of the same type feature, which we do not have right now, please create a feature request for it. I do agree that is can be beneficial for quick sketches. Immediately though many other potentially useful use-cases pop up, too. What about duplicating a diagram to a new tab? Or creating a new diagram from the current selection? My gut feeling is that we should simply remove the |
Closes #2293 * Placeholder feature is not removed with this commit, since we might want to re-use it in the future
Closes #2293 * Placeholder feature is not removed with this commit, since we might want to re-use it in the future
It looks confusing as you press a button the right side of the screen, but the result appears somewhere on the left (nearly unpredictable). But thanks for providing the video, it makes it easier to visualize and judge it. |
Closed via #2308 |
What should we do?
Remove the
+
button. Display the (uncloseable) empty tab with the labelWelcome
only if no other tab is opened.Why should we do it?
Starting with Camunda Cloud the
+
button becomes even more ambiguous. Especially given our current strict separation between execution platforms this can lead to undesired behavior for the user, cf. #2283.The text was updated successfully, but these errors were encountered: