Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove + button #2293

Closed
nikku opened this issue Jun 1, 2021 · 10 comments
Closed

Remove + button #2293

nikku opened this issue Jun 1, 2021 · 10 comments
Assignees
Labels
enhancement New feature or request ux
Milestone

Comments

@nikku
Copy link
Member

nikku commented Jun 1, 2021

What should we do?

Remove the + button. Display the (uncloseable) empty tab with the label Welcome only if no other tab is opened.

Empty tab

Why should we do it?

Starting with Camunda Cloud the + button becomes even more ambiguous. Especially given our current strict separation between execution platforms this can lead to undesired behavior for the user, cf. #2283.

@nikku nikku added the enhancement New feature or request label Jun 1, 2021
@nikku nikku changed the title Remove + button Remove + button or mitigate current behavior Jun 1, 2021
@andreasgeier
Copy link

The plus button was part of the unified modeler concept but we did not find the time to implement the solution. I'm fine with removing it (at least as an intermediate fix) since this causes trouble now.

@andreasgeier andreasgeier added the ux label Jun 1, 2021
@nikku nikku changed the title Remove + button or mitigate current behavior Remove + button Jun 1, 2021
@nikku nikku added the ready Ready to be worked on label Jun 1, 2021
@nikku nikku added this to the M48 milestone Jun 1, 2021
@falko
Copy link
Member

falko commented Jun 4, 2021

I frequently use the + button in customer meetings to quickly start a new diagram of the same type for sketching something on the side.

Please consider keeping the + button and let it create the same type of file as the one currently open, i.e. with the same modeling language and execution platform.

When the welcome page is shown, the button can be hidden because there is already a selection for the file type.

Once a user selected a file type for the first diagram or has opened an existing file, the most likely next action is to create more of the same.

@falko
Copy link
Member

falko commented Jun 4, 2021

Another option for power users if you insist on removing the + button would be keyboard shortcuts for all file types. But in line with my previous comment, I'd be already happy if Ctrl + T gives me more of the same.

@MaxTru
Copy link
Contributor

MaxTru commented Jun 11, 2021

Please consider keeping the + button and let it create the same type of file as the one currently open, i.e. with the same modeling language and execution platform.

This could easily be done and I personally also favor this approach - @nikku @andreasgeier was this dicussed, is there any reason why removing the + would be better?

@andreasgeier
Copy link

andreasgeier commented Jun 11, 2021

Please consider keeping the + button and let it create the same type of file as the one currently open, i.e. with the same modeling language and execution platform.

This could easily be done and I personally also favor this approach - @nikku @andreasgeier was this dicussed, is there any reason why removing the + would be better?

We should not do that. We also have to consider a scenario where multiple tabs are opened. Then it becomes hard to predict what file will be created. Even harder if we consider the scenario that at start up the Modeler re-opens multiple tabs from the last session.

The solution would not only violate the (UX) rule of not being predictable but also that the same button should always behave the same, meaning a plus should not create a BPMN this time and a DMN next time or (as an example from the prop panel) an error now and a message later.

@MaxTru
Copy link
Contributor

MaxTru commented Jun 11, 2021

I see what you mean, yet playing around with it, I do not think it is a problem. As you can see in the screencast. I dont feel it is surprising or unpredictable due to two reasons:

  • the tab is always opened directly next to the currently opened tab. Therefore it is clear that a new tab of the existing one was created
  • Practically, it becomes clear just by the looks of it, that I just created either a form, a DMN or a BPMN diagram
    • In case of BPMN-cloud vs BPMN-platform, I think practically a user would work either in one world or the other.

QuickOpenNewTab

If you want to try it yourself, test with this artifact:
https://camunda-modeler-on-demand.s3.eu-central-1.amazonaws.com/develop/camunda-modeler-develop-linux-x64.tar.gz
https://camunda-modeler-on-demand.s3.eu-central-1.amazonaws.com/develop/camunda-modeler-develop-mac.dmg
https://camunda-modeler-on-demand.s3.eu-central-1.amazonaws.com/develop/camunda-modeler-develop-mac.zip
https://camunda-modeler-on-demand.s3.eu-central-1.amazonaws.com/develop/camunda-modeler-develop-win-ia32.zip
https://camunda-modeler-on-demand.s3.eu-central-1.amazonaws.com/develop/camunda-modeler-develop-win-x64.zip


What do you think?

In the end I am not super opinionated and would also be okay with removing the button. I would just like to have a second validation now that we have this working prototype anyhow to ensure we are doing the right thing.

@nikku
Copy link
Member Author

nikku commented Jun 14, 2021

@falko @MaxTru Any change in the plus button behavior is a breaking one and needs to be properly communicated to the user. Thus my proposal to simply remove it and re-consider introducing it some day in the future (or never).

If we want a create a new document of the same type feature, which we do not have right now, please create a feature request for it. I do agree that is can be beneficial for quick sketches. Immediately though many other potentially useful use-cases pop up, too. What about duplicating a diagram to a new tab? Or creating a new diagram from the current selection?

My gut feeling is that we should simply remove the + button for the moment.

MaxTru added a commit that referenced this issue Jun 14, 2021
Closes #2293

* Placeholder feature is not removed with this commit, since we might
  want to re-use it in the future
MaxTru added a commit that referenced this issue Jun 14, 2021
Closes #2293

* Placeholder feature is not removed with this commit, since we might
  want to re-use it in the future
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Jun 14, 2021
@MaxTru
Copy link
Contributor

MaxTru commented Jun 14, 2021

I created a new issue to evaluate the feature of adding new property of currently opened type: #2309

I prepared the PR which will remove the + button: #2308

@ingorichtsmeier
Copy link

It looks confusing as you press a button the right side of the screen, but the result appears somewhere on the left (nearly unpredictable).

But thanks for providing the video, it makes it easier to visualize and judge it.

@MaxTru
Copy link
Contributor

MaxTru commented Jun 16, 2021

Closed via #2308

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ux
Projects
None yet
Development

No branches or pull requests

5 participants