Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name input interrupted when entering "L" #790

Closed
2 tasks
mschoe opened this issue Apr 26, 2018 · 4 comments
Closed
2 tasks

Name input interrupted when entering "L" #790

mschoe opened this issue Apr 26, 2018 · 4 comments
Assignees
Labels
bug Something isn't working DMN
Milestone

Comments

@mschoe
Copy link
Member

mschoe commented Apr 26, 2018

Problem

  • When entering the key <l> during direct editing in DRD view the input is interrupted and the lasso tool gets activated.

Expected Behavior

  • <l> can be typed without canceling direct editing
  • single letter key bindings activate tools outside the scope of an editable input only
@mschoe mschoe added bug Something isn't working DMN labels Apr 26, 2018
@nikku
Copy link
Member

nikku commented Apr 26, 2018

Cannot reproduce on Linux.

@nikku nikku added the help wanted Extra attention is needed label Apr 26, 2018
@mschoe mschoe changed the title Name input interrupted when entering a decision name Name input interrupted when entering "L" Apr 26, 2018
@mschoe
Copy link
Member Author

mschoe commented Apr 26, 2018

after further investigation I figured out that the character 'L' is not compatible with the name input.
Reason: by pressing 'l' the lasso tool will be activated
Solution: deactivate keyboard shortcuts while the user is in the name edit mode

@nikku nikku removed the help wanted Extra attention is needed label Apr 26, 2018
@nikku nikku added this to the M22 milestone Apr 26, 2018
@nikku nikku added the backlog Queued in backlog label Apr 26, 2018
@nikku
Copy link
Member

nikku commented Apr 26, 2018

Thanks for providing these additional details. I've update the description accordingly.

🍰

@philippfromme
Copy link
Contributor

As a workaround you can use the letter i uppercase (looks the same).

@nikku nikku modified the milestones: M23, M22 May 28, 2018
@nikku nikku added ready Ready to be worked on and removed backlog Queued in backlog labels Jun 6, 2018
@nikku nikku modified the milestones: M23, M24 Jun 6, 2018
@nikku nikku added backlog Queued in backlog and removed ready Ready to be worked on labels Jun 6, 2018
@ghost ghost assigned philippfromme Jun 15, 2018
@ghost ghost added in progress Currently worked on and removed backlog Queued in backlog labels Jun 15, 2018
@philippfromme philippfromme added needs review Review pending and removed in progress Currently worked on labels Jun 18, 2018
@philippfromme philippfromme assigned nikku and unassigned philippfromme Jun 18, 2018
philippfromme added a commit that referenced this issue Jun 18, 2018
* properly disable editor actions when direct editing is active
* remove hacks

Closes #790
philippfromme added a commit that referenced this issue Jun 18, 2018
* properly disable editor actions when direct editing is active
* remove hacks

Closes #790
@nikku nikku closed this as completed in 2966c66 Jun 19, 2018
@ghost ghost removed the needs review Review pending label Jun 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working DMN
Projects
None yet
Development

No branches or pull requests

3 participants