741 support deployment against authenticated engines #1063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Depends on #1041 |
nikku
force-pushed
the
741-support-deployment-against-authenticated-engines
branch
from
1fba919
to
ff860c3
Compare
nikku
force-pushed
the
741-support-deployment-against-authenticated-engines
branch
from
ff860c3
to
892ea89
Compare
* replace factory function with a class * enable to use Basic and Bearer strategies by passing auth object to options
nikku
force-pushed
the
741-support-deployment-against-authenticated-engines
branch
from
892ea89
to
3f699b2
Compare
* clearly separate deployment details and endpoint config * visually distinguish both * put endpoint config to bottom (less important)
nikku
force-pushed
the
741-support-deployment-against-authenticated-engines
branch
from
98e471d
to
5ba7c91
Compare
nikku
approved these changes
Dec 11, 2018
delete-merged-branch
bot
deleted the
741-support-deployment-against-authenticated-engines
branch
This was referenced Dec 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides options to authenticate deployments with HTTP Basic and Bearer methods.
Closes #741