Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deploying ingress resource per default doesn't make much sense, since not everyone has an ingress controller deployed. We decided to disable it per default.
Like its done in other charts:
Grafana
https://github.com/grafana/helm-charts/blob/main/charts/grafana/values.yaml#L183-L184
Kibana:
https://github.com/elastic/helm-charts/blob/main/kibana/values.yaml#L142-L143
Elasticsearch
https://github.com/elastic/helm-charts/blob/main/elasticsearch/values.yaml#L250-L251
BTW @menski I saw that the previous full chart deployed an ingress nginx controller https://github.com/camunda-community-hub/camunda-cloud-helm/blob/main/charts/zeebe-full-helm/Chart.yaml#L19-L21 but tbh I'm not sure whether we really want that. Plus it didn't work #146
related to #124