Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General CCSM README rewrite #151

Merged
merged 29 commits into from
Feb 6, 2022
Merged

General CCSM README rewrite #151

merged 29 commits into from
Feb 6, 2022

Conversation

Zelldon
Copy link
Member

@Zelldon Zelldon commented Feb 3, 2022

Rewrote the ccsm helm README:

  • Add toc to the readme
  • Create for each subchart a separate configuration subsection
  • Each subchart gots its own table with values documented
  • Each subchart readme points to the right section in the parent readme
  • Default values have been adjusted
  • Some other additions and improvements

relates to #124

@Zelldon Zelldon requested a review from npepinpe February 3, 2022 09:13
@Zelldon Zelldon mentioned this pull request Feb 4, 2022
25 tasks
Copy link
Member

@npepinpe npepinpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

  • 💭 The comma usages are very German 😄
  • 🙃 We use Elasticsearch and ElasticSearch interchangeably. Now I don't know which is right 😄

charts/ccsm-helm/README.md Outdated Show resolved Hide resolved
charts/ccsm-helm/README.md Outdated Show resolved Hide resolved
charts/ccsm-helm/README.md Outdated Show resolved Hide resolved
charts/ccsm-helm/README.md Outdated Show resolved Hide resolved
charts/ccsm-helm/README.md Outdated Show resolved Hide resolved
charts/ccsm-helm/convertValuesDoc.sh Show resolved Hide resolved
charts/ccsm-helm/values.yaml Show resolved Hide resolved
Zelldon and others added 5 commits February 5, 2022 22:39
Co-authored-by: Nicolas Pepin-Perreault <43373+npepinpe@users.noreply.github.com>
Co-authored-by: Nicolas Pepin-Perreault <43373+npepinpe@users.noreply.github.com>
Co-authored-by: Nicolas Pepin-Perreault <43373+npepinpe@users.noreply.github.com>
@Zelldon
Copy link
Member Author

Zelldon commented Feb 6, 2022

The comma usages are very German 

Yeah sorry. I have always issues with that, also in german 😅 It is not my strength. If you have any hints to improve or request for changes please share :)

Thanks for the review 🙇

@Zelldon Zelldon merged commit 4f13aae into main Feb 6, 2022
@Zelldon Zelldon deleted the zell-general-readme-rewrite branch February 6, 2022 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants