Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework config map's #154

Merged
merged 2 commits into from
Feb 4, 2022
Merged

Rework config map's #154

merged 2 commits into from
Feb 4, 2022

Conversation

Zelldon
Copy link
Member

@Zelldon Zelldon commented Feb 4, 2022

Reworks the zeebe config maps which are deployed with the services/applications.

I tried it out and the following is calculated correctly:

$ k logs test-zeebe-0

+ env
...
ZEEBE_BROKER_CLUSTER_NODEID=0
ZEEBE_BROKER_CLUSTER_CLUSTERNAME=test-zeebe
ZEEBE_BROKER_CLUSTER_INITIALCONTACTPOINTS=test-zeebe-0.test-zeebe.zell-helm-test.svc.cluster.local, test-zeebe-1.test-zeebe.zell-helm-test.svc.cluster.local, test-zeebe-2.test-zeebe.zell-helm-test.svc.cluster.local,
...
K8S_NAMESPACE=zell-helm-test
K8S_SERVICE_NAME=test-zeebe
K8S_NAME=test-zeebe-0

\cc Maybe interesting for you @Sijoma (I can still not request a review from you)

related to #124

In order to have everything in one place and for better maintainability most of the env vars should be set in the statefulset manifest. This is done via this commit. The env vars can be calculated via kubernetes dependent environment variables, which are expanded at deploy time. The initial contact points can be calculated with helm template magic.
@Zelldon Zelldon requested a review from menski February 4, 2022 08:01
@Sijoma
Copy link

Sijoma commented Feb 4, 2022

Seems way cleaner 👍 . I wonder what it would take to have a dynamic discovery mechanism?

Would this also be a PR for our "other" repo? 😉

@Zelldon
Copy link
Member Author

Zelldon commented Feb 4, 2022

Seems way cleaner  . I wonder what it would take to have a dynamic discovery mechanism?

Yeah would also be cool :) unfortunately currently not possible.

Yes I just wanted to check with you how you like it 😄 and then I wanted to create a PR their 😬

Thanks for the review @Sijoma ❤️

@Zelldon Zelldon merged commit 8692485 into main Feb 4, 2022
@Zelldon Zelldon deleted the zell-rework-config-map branch February 4, 2022 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants