Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade to ship Keycloak v22 #889

Merged
merged 2 commits into from
Sep 29, 2023

Conversation

Ben-Sheppard
Copy link
Contributor

@Ben-Sheppard Ben-Sheppard commented Sep 14, 2023

Which problem does the PR fix?

Closes #849

What's in this PR?

This PR contains a couple of smaller changes (and one larger one!), these are:

  1. Upgrade the base Keycloak chart to one that supports Keycloak 22.0.1 (in prep for 8.3)
  2. Updates the defaulted Keycloak version from 19.0.3 -> 22.0.1
  3. Sets the keycloak.proxy value to edge (this is required to allow the Keycloak UI to load

I have tested this locally the best I can, these tests cover mainly:

  1. I can deploy a clean cluster with Keycloak 22, access applications, and deploy a model
  2. I can upgrade a cluster from Keycloak 19 -> 22, access applications (no model deployment testing here)

Checklist

Please make sure to follow our Contributing Guide.

Before opening the PR:

  • There is no other open pull request for the same update/change.
  • The commits follow our Commit Guidelines.
  • The main Helm chart and sub-chart are updated (if needed).
  • In-repo documentation are updated (if needed).

After opening the PR:

  • Did you sign our CLA (Contributor License Agreement)? It will show once you open the PR.
  • Did all checks/tests pass in the PR?

@github-actions github-actions bot temporarily deployed to gke-889 September 14, 2023 13:08 Destroyed
@github-actions github-actions bot temporarily deployed to rosa-889 September 14, 2023 13:09 Destroyed
@aabouzaid
Copy link
Member

@Ben-Sheppard thanks for the PR 🙇
I will take a look at it soon.
but now I will just change this to a draft since it has a breaking change that will not be merged before 8.3 (to avoid accidental merge).

@aabouzaid aabouzaid marked this pull request as draft September 14, 2023 17:20
@aabouzaid aabouzaid added kind/breaking-change A change that potentially causes other components to fail and needs a migration steps/guide feature Indicates a new feature request labels Sep 21, 2023
@aabouzaid aabouzaid added kind/enhancement New feature or request and removed feature Indicates a new feature request labels Sep 28, 2023
@aabouzaid aabouzaid force-pushed the 849-upgrade-keycloak-version-to-22 branch from d7a8224 to 0510d03 Compare September 28, 2023 13:38
@github-actions github-actions bot temporarily deployed to gke-889 September 28, 2023 13:40 Destroyed
@github-actions github-actions bot temporarily deployed to rosa-889 September 28, 2023 13:40 Destroyed
@github-actions github-actions bot temporarily deployed to gke-889 September 28, 2023 14:02 Destroyed
@github-actions github-actions bot temporarily deployed to gke-889 September 28, 2023 14:02 Destroyed
@github-actions github-actions bot temporarily deployed to gke-889 September 28, 2023 14:02 Destroyed
@github-actions github-actions bot temporarily deployed to gke-889 September 28, 2023 14:02 Destroyed
@github-actions github-actions bot temporarily deployed to rosa-889 September 28, 2023 14:02 Destroyed
@github-actions github-actions bot temporarily deployed to rosa-889 September 28, 2023 14:02 Destroyed
@aabouzaid aabouzaid force-pushed the 849-upgrade-keycloak-version-to-22 branch from c0cbc09 to 7ca29d0 Compare September 29, 2023 10:47
@github-actions github-actions bot temporarily deployed to gke-889 September 29, 2023 10:48 Destroyed
@github-actions github-actions bot temporarily deployed to gke-889 September 29, 2023 10:48 Destroyed
@github-actions github-actions bot temporarily deployed to rosa-889 September 29, 2023 10:48 Destroyed
@aabouzaid aabouzaid force-pushed the 849-upgrade-keycloak-version-to-22 branch from 7ca29d0 to f06a719 Compare September 29, 2023 12:44
@github-actions github-actions bot temporarily deployed to gke-889 September 29, 2023 12:45 Destroyed
@github-actions github-actions bot temporarily deployed to rosa-889 September 29, 2023 12:45 Destroyed
@github-actions github-actions bot temporarily deployed to rosa-889 September 29, 2023 12:45 Destroyed
@github-actions github-actions bot temporarily deployed to gke-889 September 29, 2023 12:45 Destroyed
@github-actions github-actions bot temporarily deployed to rosa-889 September 29, 2023 13:03 Destroyed
@github-actions github-actions bot temporarily deployed to gke-889 September 29, 2023 13:14 Destroyed
@github-actions github-actions bot temporarily deployed to gke-889 September 29, 2023 13:14 Destroyed
@github-actions github-actions bot temporarily deployed to rosa-889 September 29, 2023 13:14 Destroyed
@github-actions github-actions bot temporarily deployed to rosa-889 September 29, 2023 13:15 Destroyed
@aabouzaid aabouzaid force-pushed the 849-upgrade-keycloak-version-to-22 branch from 60620cb to 73ec43c Compare September 29, 2023 13:39
@github-actions github-actions bot temporarily deployed to gke-889 September 29, 2023 13:40 Destroyed
@github-actions github-actions bot temporarily deployed to gke-889 September 29, 2023 13:40 Destroyed
@github-actions github-actions bot temporarily deployed to rosa-889 September 29, 2023 13:40 Destroyed
@github-actions github-actions bot temporarily deployed to rosa-889 September 29, 2023 13:40 Destroyed
@aabouzaid aabouzaid force-pushed the 849-upgrade-keycloak-version-to-22 branch from 73ec43c to d91bfdb Compare September 29, 2023 15:15
@github-actions github-actions bot temporarily deployed to gke-889 September 29, 2023 15:16 Destroyed
@github-actions github-actions bot temporarily deployed to rosa-889 September 29, 2023 15:16 Destroyed
@github-actions github-actions bot temporarily deployed to rosa-889 September 29, 2023 15:16 Destroyed
@github-actions github-actions bot temporarily deployed to gke-889 September 29, 2023 15:16 Destroyed
@aabouzaid aabouzaid force-pushed the 849-upgrade-keycloak-version-to-22 branch from d91bfdb to 16df804 Compare September 29, 2023 16:07
@github-actions github-actions bot temporarily deployed to gke-889 September 29, 2023 16:08 Destroyed
@github-actions github-actions bot temporarily deployed to rosa-889 September 29, 2023 16:08 Destroyed
@github-actions github-actions bot temporarily deployed to rosa-889 September 29, 2023 16:08 Destroyed
@github-actions github-actions bot temporarily deployed to gke-889 September 29, 2023 16:08 Destroyed
@github-actions github-actions bot temporarily deployed to gke-889 September 29, 2023 16:54 Destroyed
@aabouzaid aabouzaid marked this pull request as ready for review September 29, 2023 20:19
@aabouzaid aabouzaid merged commit 9968bd0 into main Sep 29, 2023
11 checks passed
@aabouzaid aabouzaid deleted the 849-upgrade-keycloak-version-to-22 branch September 29, 2023 20:20
aabouzaid pushed a commit that referenced this pull request Sep 29, 2023
BREAKING CHANGE

Even though there is no breaking change found, the upgrade should be handled with carefully because the Keycloak major version upgrade.
aabouzaid pushed a commit that referenced this pull request Sep 29, 2023
Even though there is no breaking change found, the upgrade should be handled with carefully because the Keycloak major version upgrade.
aabouzaid pushed a commit that referenced this pull request Sep 29, 2023
Even though there is no breaking change found,
the upgrade should be handled carefully
because the Keycloak major version upgrade.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/breaking-change A change that potentially causes other components to fail and needs a migration steps/guide kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK] Upgrade to Keycloak v22 for 8.3 release
2 participants