Skip to content

Commit

Permalink
merge: #8999 #9017
Browse files Browse the repository at this point in the history
8999: Add commit and record write quantile panels r=Zelldon a=Zelldon

## Description

Taking a look at performance issues often forces me at the end to look at the commit latencies, because of #8551 It is currently quite hard to compare latencies from two benchmarks, since this is show as a heatmap. 

![old-panels](https://user-images.githubusercontent.com/2758593/160366627-bfd3e8f3-9c59-4bd6-8831-6df5f4a6e8ca.png)

This PR should solve this issue, and allows me to not always recreate my panels (to see a difference).

It addes two new panels, one for the commit latency and one for the record write latency. Both show the quantiles (p90, p99), the median and the avg. 

The formulars were based on :  https://theswissbay.ch/pdf/Books/Computer%20science/prometheus_upandrunning.pdf (I use the book)


The new panels look like this:

![new-panels](https://user-images.githubusercontent.com/2758593/160366881-52720cfc-1bcd-4d46-8055-27c59a873c64.png)

this allows to easier compare it to other benchmark which perform worse like:

![otherbench-new-panels](https://user-images.githubusercontent.com/2758593/160366975-ffc7ac5d-3488-4ea7-9fd9-0839b365bfb1.png)


<!-- Please explain the changes you made here. -->

## Related issues

<!-- Which issues are closed by this PR or are related -->

related to #8551



9017: chore(maven): add trailing slashes to new Artifactory URL r=cmur2 a=cmur2

## Description

I got review feedback that it is recommended to have trailing slashes to the URL so I'm adding them for consistency.

## Related issues

Related to INFRA-3107

Co-authored-by: Christopher Zell <zelldon91@googlemail.com>
Co-authored-by: Christian Nicolai <christian.nicolai@camunda.com>
  • Loading branch information
3 people committed Mar 29, 2022
3 parents 556d379 + 17c99bb + 30f07bd commit 084d197
Show file tree
Hide file tree
Showing 3 changed files with 339 additions and 42 deletions.
4 changes: 2 additions & 2 deletions benchmarks/project/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@
</snapshots>
<id>zeebe</id>
<name>Zeebe Repository</name>
<url>https://artifacts.camunda.com/artifactory/zeebe-io</url>
<url>https://artifacts.camunda.com/artifactory/zeebe-io/</url>
</repository>

<repository>
Expand All @@ -113,7 +113,7 @@
</snapshots>
<id>zeebe-snapshots</id>
<name>Zeebe Snapshot Repository</name>
<url>https://artifacts.camunda.com/artifactory/zeebe-io-snapshots</url>
<url>https://artifacts.camunda.com/artifactory/zeebe-io-snapshots/</url>
</repository>
</repositories>

Expand Down
8 changes: 4 additions & 4 deletions bom/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,8 @@

<properties>
<!-- release parent settings -->
<nexus.snapshot.repository>https://artifacts.camunda.com/artifactory/zeebe-io-snapshots</nexus.snapshot.repository>
<nexus.release.repository>https://artifacts.camunda.com/artifactory/zeebe-io</nexus.release.repository>
<nexus.snapshot.repository>https://artifacts.camunda.com/artifactory/zeebe-io-snapshots/</nexus.snapshot.repository>
<nexus.release.repository>https://artifacts.camunda.com/artifactory/zeebe-io/</nexus.release.repository>
<nexus.sonatype.url>https://s01.oss.sonatype.org</nexus.sonatype.url>

<plugin.version.flatten>1.2.7</plugin.version.flatten>
Expand Down Expand Up @@ -87,7 +87,7 @@
</snapshots>
<id>zeebe</id>
<name>Zeebe Repository</name>
<url>https://artifacts.camunda.com/artifactory/zeebe-io</url>
<url>https://artifacts.camunda.com/artifactory/zeebe-io/</url>
</repository>

<repository>
Expand All @@ -99,7 +99,7 @@
</snapshots>
<id>zeebe-snapshots</id>
<name>Zeebe Snapshot Repository</name>
<url>https://artifacts.camunda.com/artifactory/zeebe-io-snapshots</url>
<url>https://artifacts.camunda.com/artifactory/zeebe-io-snapshots/</url>
</repository>
</repositories>

Expand Down
Loading

0 comments on commit 084d197

Please sign in to comment.