-
Notifications
You must be signed in to change notification settings - Fork 584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write an event if a decision evaluation failed #8235
Comments
@saig0 would we get some kind of error message in the decision event? Or what would be a way for the user to understand why the decision failed? |
FYI @nazlikaya |
@menski good point 👍 I updated the description to add a new property |
@saig0 will it be a single message or is it possible to have multiple error messages in an instance? |
@nazlikaya it will be a single message. At the moment, the evaluation is interrupted if something goes wrong (i.e. a missing variable or violation of the decision table's hit policy). At some point in the future, we may have more information about the evaluation. For example, if the evaluation of a FEEL expression returns |
8330: Create a new module for DMN r=saig0 a=saig0 ## Description * create a new module `dmn` for parsing and evaluating of DMN decisions * add a method to parse a DMN decision * the parsed decision is returned as an object and should be used to evaluate the decision * if the DMN is not valid then return an object that contains the failure message * decided against the usage of `Either` to align with the evaluation method (that will be added later) * if the evaluation fails then it should return the failure message but also the history of the evaluated decision (see #8235) * the result of a successful evaluation is similar to a not successful one - so, we probably want to use the same result restructure instead of an `Either` type ## Related issues closes #8063 Co-authored-by: Philipp Ossler <philipp.ossler@gmail.com>
SuggestionWe could add an additional property |
Description
If a business rule task is activated and the evaluation of a decision fails (e.g. missing variables, unexpected variable type, etc.) then we should create an incident. Additionally, we should write an event that reflects the partial evaluation of the decision. It may helps the user to understand what went wrong.
failed
evaluationFailure
that contains the failure messagefailedDecisionId
that contains the id of the failed decisionblocked by #8115
blocked by #8095
The text was updated successfully, but these errors were encountered: