Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: disable batch processing by default on 8.1 #11631

Merged
9 commits merged into from
Feb 14, 2023
Merged

fix: disable batch processing by default on 8.1 #11631

9 commits merged into from
Feb 14, 2023

Conversation

lenaschoenburg
Copy link
Member

Updates config templates and default config to disable batch processing by default

relates to #11539

Base automatically changed from zell-backport-broker-config-bp to stable/8.1 February 13, 2023 09:33
@github-actions
Copy link
Contributor

github-actions bot commented Feb 13, 2023 •
edited

Test Results

   775 files   -    142     775 suites   - 142   1h 29m 3s ⏱️ + 9m 43s
6 167 tests  - 1 159  6 159 ✔️  - 1 148  8 💤 ±0  0 ❌ ±0 
6 351 runs   - 1 169  6 343 ✔️  - 1 158  8 💤 ±0  0 ❌ ±0 

Results for commit 97532f6. ± Comparison against base commit 1de3a85.

♻️ This comment has been updated with latest results.

@Zelldon
test: match type record
7cf534a 
In order to only return the result on a specific command we need to match the typed record
@Zelldon
test: adjust filter limit
39c87e1
@Zelldon
Copy link
Member

Zelldon commented Feb 13, 2023

@oleschoenburg I updated the PR should work now.

@Zelldon
Copy link
Member

Zelldon commented Feb 14, 2023

@oleschoenburg could just fix the last remaining test:

Error:  Failures: 
Error:    ProcessingCfgTest.shouldUseDefaultMaxCommandsInBatch:27 
expected: 100
 but was: 1

Zelldon
Zelldon approved these changes Feb 14, 2023
View reviewed changes
Copy link
Member

@Zelldon Zelldon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@lenaschoenburg
Copy link
Member Author

bors r+

@ghost
Copy link

ghost commented Feb 14, 2023

Build succeeded:

@ghost ghost merged commit be36dd4 into stable/8.1 Feb 14, 2023
@ghost ghost deleted the oz-disable-batch-proc-by-default branch February 14, 2023 08:13
@lenaschoenburg lenaschoenburg mentioned this pull request Feb 14, 2023
Closed
19 tasks
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zelldon Zelldon Zelldon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lenaschoenburg @Zelldon