-
Notifications
You must be signed in to change notification settings - Fork 579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable receiver to parse chunked file snapshot chunks #19490
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeebe/atomix/cluster/src/main/java/io/atomix/raft/snapshot/impl/SnapshotChunkImpl.java
Outdated
Show resolved
Hide resolved
zeebe/snapshot/src/main/java/io/camunda/zeebe/snapshots/impl/FileBasedReceivedSnapshot.java
Outdated
Show resolved
Hide resolved
zeebe/snapshot/src/main/java/io/camunda/zeebe/snapshots/impl/FileBasedReceivedSnapshot.java
Outdated
Show resolved
Hide resolved
zeebe/atomix/cluster/src/main/java/io/atomix/raft/snapshot/impl/SnapshotChunkImpl.java
Outdated
Show resolved
Hide resolved
zeebe/snapshot/src/main/java/io/camunda/zeebe/snapshots/impl/SfvChecksumImpl.java
Outdated
Show resolved
Hide resolved
zeebe/snapshot/src/main/java/io/camunda/zeebe/snapshots/impl/SfvChecksumImpl.java
Outdated
Show resolved
Hide resolved
zeebe/snapshot/src/main/java/io/camunda/zeebe/snapshots/impl/SfvChecksumImpl.java
Outdated
Show resolved
Hide resolved
692c311
to
8396cc6
Compare
a0f5efe
to
016edeb
Compare
6b85129
to
0834636
Compare
lenaschoenburg
requested changes
Jun 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Let's not close #12795 yet, we need to find a sensible default value that's lower than 1GiB
zeebe/atomix/cluster/src/main/java/io/atomix/raft/roles/PassiveRole.java
Outdated
Show resolved
Hide resolved
zeebe/snapshot/src/main/java/io/camunda/zeebe/snapshots/impl/FileBasedReceivedSnapshot.java
Show resolved
Hide resolved
zeebe/snapshot/src/main/java/io/camunda/zeebe/snapshots/impl/FileBasedReceivedSnapshot.java
Show resolved
Hide resolved
25c0fd3
to
f199c5a
Compare
lenaschoenburg
requested changes
Jun 25, 2024
zeebe/snapshot/src/main/java/io/camunda/zeebe/snapshots/impl/SnapshotChunkId.java
Outdated
Show resolved
Hide resolved
zeebe/snapshot/src/main/java/io/camunda/zeebe/snapshots/impl/FileBasedReceivedSnapshot.java
Show resolved
Hide resolved
zeebe/snapshot/src/main/java/io/camunda/zeebe/snapshots/impl/FileBasedSnapshotChunkReader.java
Show resolved
Hide resolved
zeebe/snapshot/src/main/java/io/camunda/zeebe/snapshots/impl/FileBasedSnapshotChunkReader.java
Outdated
Show resolved
Hide resolved
lenaschoenburg
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component/operate
Related to the Operate component/team
component/tasklist
Related to the Tasklist component/team
component/zeebe
Related to the Zeebe component/team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Built on the changes in #19361 as new chunk fields are needed.
chunkId
inPassiveRole
Related issues
closes #12795