-
Notifications
You must be signed in to change notification settings - Fork 579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: users groups have roles identity backend #19518
Conversation
…groups-have-roles-identity-backend
…' into 2948-2929-users-groups-have-roles-identity-backend
…' into 2948-2949-users-groups-have-roles-identity-backend
…groups-have-roles-identity-backend
…' into 2948-2949-users-groups-have-roles-identity-backend
…s-have-roles-identity-backend
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code seems fine to me, achieves what you've set out to do, I mainly just have styling based comments
.../backend/src/main/java/io/camunda/identity/rolemanagement/service/RoleMembershipService.java
Outdated
Show resolved
Hide resolved
.../backend/src/main/java/io/camunda/identity/rolemanagement/service/RoleMembershipService.java
Outdated
Show resolved
Hide resolved
.../backend/src/main/java/io/camunda/identity/rolemanagement/service/RoleMembershipService.java
Outdated
Show resolved
Hide resolved
.../backend/src/main/java/io/camunda/identity/rolemanagement/service/RoleMembershipService.java
Show resolved
Hide resolved
.../backend/src/main/java/io/camunda/identity/rolemanagement/service/RoleMembershipService.java
Outdated
Show resolved
Hide resolved
.../backend/src/main/java/io/camunda/identity/rolemanagement/service/RoleMembershipService.java
Show resolved
Hide resolved
.../backend/src/main/java/io/camunda/identity/rolemanagement/service/RoleMembershipService.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for addressing my comments, looks good from my side
…s-have-roles-identity-backend
Description
Related issues
closes https://github.com/camunda-cloud/identity/issues/2948
closes https://github.com/camunda-cloud/identity/issues/2949