Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: users groups have roles identity backend #19518

Merged
17 commits merged into from
Jun 24, 2024

Conversation

ghost
Copy link

@ghost ghost commented Jun 19, 2024

Description

  • roles can be read from, assigned to, and unassigned from users and groups

Related issues

closes https://github.com/camunda-cloud/identity/issues/2948
closes https://github.com/camunda-cloud/identity/issues/2949

Steffen Pade added 4 commits June 19, 2024 09:20
@ghost ghost self-assigned this Jun 19, 2024
@github-actions github-actions bot added the component/identity Related to the Identity component/team label Jun 19, 2024
@ghost ghost marked this pull request as ready for review June 21, 2024 12:05
@ghost ghost self-requested a review June 21, 2024 12:06
@ghost ghost changed the title DRAFT: feat: users groups have roles identity backend feat: users groups have roles identity backend Jun 21, 2024
Copy link
Contributor

@Ben-Sheppard Ben-Sheppard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code seems fine to me, achieves what you've set out to do, I mainly just have styling based comments

@ghost ghost requested review from Ben-Sheppard and dlavrenuek June 24, 2024 06:06
Copy link
Contributor

@Ben-Sheppard Ben-Sheppard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for addressing my comments, looks good from my side

@ghost ghost added this pull request to the merge queue Jun 24, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 24, 2024
@ghost ghost added this pull request to the merge queue Jun 24, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 24, 2024
@ghost ghost added this pull request to the merge queue Jun 24, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 24, 2024
@ghost ghost added this pull request to the merge queue Jun 24, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 24, 2024
@ghost ghost added this pull request to the merge queue Jun 24, 2024
Merged via the queue into main with commit b34c4a1 Jun 24, 2024
26 checks passed
@ghost ghost deleted the 2948-2949-users-groups-have-roles-identity-backend branch June 24, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/identity Related to the Identity component/team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants