-
Notifications
You must be signed in to change notification settings - Fork 579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make sdk properties tests able to run in parallel #19529
Conversation
Hey @Zelldon this change should fix the issue with the unified CI 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Nic for the quick look at it. Unfortunately, I'm not sure whether we should do it like this. Maybe we can find something else.
.../src/test/java/io/camunda/zeebe/spring/client/config/CredentialsProviderSelfManagedTest.java
Outdated
Show resolved
Hide resolved
7eed2ca
to
6a3b7c3
Compare
Should I remove also this workflow https://github.com/camunda/camunda/blob/main/.github/workflows/spring-boot-starter-camunda-sdk-ci.yml @Zelldon ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great thanks for fixing and adjusting :) @nicpuppa 🚀
[INFO] Camunda Spring SDK ................................. SUCCESS [ 24.671 s]
If we are sure that we completely cover all tests (and there are no IT tests missing), then yes I think we can rid of the other workflow 🚀 👍🏼
...nda-sdk/src/test/java/io/camunda/zeebe/spring/client/config/CredentialsProviderSaasTest.java
Outdated
Show resolved
Hide resolved
.../src/test/java/io/camunda/zeebe/spring/client/config/CredentialsProviderSelfManagedTest.java
Outdated
Show resolved
Hide resolved
.../src/test/java/io/camunda/zeebe/spring/client/config/CredentialsProviderSelfManagedTest.java
Show resolved
Hide resolved
@Zelldon I checked the Spring SDK tests and everything seems ok. I also removed the rule from the branch protection on main. I'm going to merge this PR 👍 |
3198ea7
to
2faeaf2
Compare
2faeaf2
to
817de3b
Compare
Description
In order to enable SDK unit's test to be used in the unified ci we need to make sure that those tests can run in parallel
Related issues
closes #19520