fix: make sdk properties tests able to run in parallel #19529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @Zelldon this change should fix the issue with the unified CI 👍 |
Zelldon
requested changes
Jun 19, 2024
.../src/test/java/io/camunda/zeebe/spring/client/config/CredentialsProviderSelfManagedTest.java
Outdated
Show resolved
Hide resolved
nicpuppa
force-pushed
the
19520-fix-sdk-tests
branch
from
7eed2ca
to
6a3b7c3
Compare
|
Should I remove also this workflow https://github.com/camunda/camunda/blob/main/.github/workflows/spring-boot-starter-camunda-sdk-ci.yml @Zelldon ? |
Zelldon
approved these changes
Jun 20, 2024
There was a problem hiding this comment.
Great thanks for fixing and adjusting :) @nicpuppa 🚀
[INFO] Camunda Spring SDK ................................. SUCCESS [ 24.671 s]
If we are sure that we completely cover all tests (and there are no IT tests missing), then yes I think we can rid of the other workflow 🚀 👍🏼
...nda-sdk/src/test/java/io/camunda/zeebe/spring/client/config/CredentialsProviderSaasTest.java
Outdated
Show resolved
Hide resolved
.../src/test/java/io/camunda/zeebe/spring/client/config/CredentialsProviderSelfManagedTest.java
Outdated
Show resolved
Hide resolved
.../src/test/java/io/camunda/zeebe/spring/client/config/CredentialsProviderSelfManagedTest.java
Show resolved
Hide resolved
|
@Zelldon I checked the Spring SDK tests and everything seems ok. I also removed the rule from the branch protection on main. I'm going to merge this PR 👍 |
nicpuppa
force-pushed
the
19520-fix-sdk-tests
branch
from
3198ea7
to
2faeaf2
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
nicpuppa
force-pushed
the
19520-fix-sdk-tests
branch
from
2faeaf2
to
817de3b
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In order to enable SDK unit's test to be used in the unified ci we need to make sure that those tests can run in parallel
Related issues
closes #19520