Enable gateway to use reverse proxy for cluster communication #9572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npepinpe
force-pushed
the
9342-gateway-proxy
branch
from
c57d618
to
001f16b
Compare
|
There's a flaky test, but it seems unrelated to the changes here. |
deepthidevaki
requested changes
Jun 23, 2022
dist/src/main/java/io/camunda/zeebe/gateway/AtomixComponent.java
Outdated
Show resolved
Hide resolved
deepthidevaki
approved these changes
Jun 23, 2022
npepinpe
force-pushed
the
9342-gateway-proxy
branch
from
0a1ff00
to
5b79f89
Compare
|
bors merge |
|
Build succeeded: |
zeebe-bors-camunda bot
added a commit
that referenced
this pull request
Jul 3, 2022
9669: fix: advertised address should fall back to configured address r=oleschoenburg a=oleschoenburg ## Description Since we introduced support for advertised addresses in the gateway in #9572, the atomix communication services were bound to the default host and port (0.0.0.0:26502) if no advertised address was configured instead of falling back to the configured host and port first. ## Related issues closes #9658 because job available notifications were not received which caused the delay in job activation. Co-authored-by: Ole Schönburg <ole.schoenburg@gmail.com> Co-authored-by: Christopher Zell <zelldon91@googlemail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the advertised host/port configuration to the cluster configuration of the standalone gateway. This enables the use case where the gateway and broker must communicate with a reverse proxy in between, such as when one is using a sidecar-contained based service mesh (e.g. Istio or Linkerd).
To improve test-ability, I extracted the creation of the
AtomixClusterinto a Spring component which is injected when the standalone gateway starts. That way we can test the component by itself. There's still an integration test which ensures it works end-to-end of course.Related issues
closes #9342
Definition of Done
Not all items need to be done depending on the issue and the pull request.
Code changes:
backport stable/1.3) to the PR, in case that fails you need to create backports manually.Testing:
Documentation:
Please refer to our review guidelines.