fix: advertised address should fall back to configured address #9669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If no advertised host and port are configured, we need to fall back to the configured host and port and not to the default host and port.
Zelldon
reviewed
Jul 1, 2022
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| // then | ||
| assertThat(actual.getCluster().getAdvertisedHost()).isEqualTo(expectedHost); | ||
| assertThat(actual.getCluster().getAdvertisedPort()).isEqualTo(Integer.parseInt(expectedPort)); |
Check notice
Code scanning / CodeQL
Missing catch of NumberFormatException
|
I agree, but I'd like to do this as a follow up since I'd like to include this fix in the next alpha release. See #9670 |
Add regression test which fails on SNAPSHOT, the job notification is missed in that case. With the fix the test is green.
|
I created an integration test (regression test), which fails with SNAPSHOT and is green with |
Zelldon
approved these changes
Jul 1, 2022
npepinpe
reviewed
Jul 2, 2022
qa/integration-tests/src/test/java/io/camunda/zeebe/it/clustering/LongPollingIT.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Nicolas Pepin-Perreault <43373+npepinpe@users.noreply.github.com>
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since we introduced support for advertised addresses in the gateway in #9572, the atomix communication services were bound to the default host and port (0.0.0.0:26502) if no advertised address was configured instead of falling back to the configured host and port first.
Related issues
closes #9658 because job available notifications were not received which caused the delay in job activation.