Unqork #2278
Merged
Unqork #2278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnBgood
reviewed
Mar 29, 2024
There was a problem hiding this comment.
Nice improvement thank you!
Would be nice to have a UT to illustrate this new behavior (maybe in HttpOutboundElementTemplateBuilderTest).
Last thing, did you test the generated template with a request using an Integer param? Just to be sure :)
Thank you again!
...or/http-dsl/src/main/java/io/camunda/connector/generator/dsl/http/HttpOperationProperty.java
Outdated
Show resolved
Hide resolved
...rator/openapi-parser/src/main/java/io/camunda/connector/generator/openapi/util/BodyUtil.java
Outdated
Show resolved
Hide resolved
.../openapi-parser/src/main/java/io/camunda/connector/generator/openapi/util/ParameterUtil.java
Outdated
Show resolved
Hide resolved
...or/http-dsl/src/main/java/io/camunda/connector/generator/dsl/http/HttpOperationProperty.java
Outdated
Show resolved
Hide resolved
|
Thanks for your review @johnBgood! I'll go thru and update the code per your suggestions asap. I was able to import the element template json into Camunda Web Modeler 🎉 Next step is to test it out in an actual process ... I'll keep you posted 🙂 |
|
Hey @upgradingdave ✋ Just following-up, did you have any chance to test the changes in a process? |
johnBgood
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow for parsing integers found in ENUM section of open api specs
See issue #2277 for more details. This patch addresses that issue.
Related issues
closes #2277