-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unqork #2278
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice improvement thank you!
Would be nice to have a UT to illustrate this new behavior (maybe in HttpOutboundElementTemplateBuilderTest).
Last thing, did you test the generated template with a request using an Integer param? Just to be sure :)
Thank you again!
...or/http-dsl/src/main/java/io/camunda/connector/generator/dsl/http/HttpOperationProperty.java
Outdated
Show resolved
Hide resolved
...rator/openapi-parser/src/main/java/io/camunda/connector/generator/openapi/util/BodyUtil.java
Outdated
Show resolved
Hide resolved
.../openapi-parser/src/main/java/io/camunda/connector/generator/openapi/util/ParameterUtil.java
Outdated
Show resolved
Hide resolved
...or/http-dsl/src/main/java/io/camunda/connector/generator/dsl/http/HttpOperationProperty.java
Outdated
Show resolved
Hide resolved
Thanks for your review @johnBgood! I'll go thru and update the code per your suggestions asap. I was able to import the element template json into Camunda Web Modeler 🎉 Next step is to test it out in an actual process ... I'll keep you posted 🙂 |
Hey @upgradingdave ✋ Just following-up, did you have any chance to test the changes in a process? |
Description
Allow for parsing integers found in ENUM section of open api specs
See issue #2277 for more details. This patch addresses that issue.
Related issues
closes #2277