fix(inbound): invalid inbound connector definitions are not stored #2504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chillleader
changed the title
chillleader
force-pushed
the
fix-invalid-definition-handling-in-executable-registry
branch
from
963ed9b
to
be760af
Compare
ev-codes
requested changes
May 8, 2024
There was a problem hiding this comment.
@chillleader Thanks for turning this around good work so quickly!
I left a few comments - feel free to answer the non-blocking ones post-merge (or create a new issue for them if you'd like).
I'd appreciate another teammate (@sbuettner or @johnBgood perhaps?) giving the final approval, as I haven't worked with inbound connector code that much yet!
...me-core/src/main/java/io/camunda/connector/runtime/core/inbound/InboundConnectorDetails.java
Outdated
Show resolved
Hide resolved
...me-core/src/main/java/io/camunda/connector/runtime/core/inbound/InboundConnectorDetails.java
Outdated
Show resolved
Hide resolved
...ore/src/test/java/io/camunda/connector/runtime/core/inbound/InboundConnectorDetailsTest.java
Show resolved
Hide resolved
...me-core/src/main/java/io/camunda/connector/runtime/core/inbound/InboundConnectorDetails.java
Outdated
Show resolved
Hide resolved
...test/java/io/camunda/connector/runtime/inbound/executable/InboundExecutableRegistryTest.java
Outdated
Show resolved
Hide resolved
...main/java/io/camunda/connector/runtime/inbound/executable/InboundExecutableRegistryImpl.java
Outdated
Show resolved
Hide resolved
.../src/main/java/io/camunda/connector/runtime/inbound/executable/BatchExecutableProcessor.java
Show resolved
Hide resolved
sbuettner
previously approved these changes
May 8, 2024
ev-codes
approved these changes
May 8, 2024
...mplate-generator/core/src/main/java/io/camunda/connector/generator/dsl/CommonProperties.java
Show resolved
Hide resolved
chillleader
deleted the
fix-invalid-definition-handling-in-executable-registry
branch
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release/8.6
git worktree add -d .worktree/backport-2504-to-release/8.6 origin/release/8.6
cd .worktree/backport-2504-to-release/8.6
git switch --create backport-2504-to-release/8.6
git cherry-pick -x 2866c41afbac4846315400a616e10bcd4a96941a |
chillleader
added a commit
that referenced
this pull request
May 8, 2024
…2504) * fix(inbound): invalid definitions are not stored for user convenience * fix polling connector test * address review suggestions fix test
chillleader
added a commit
that referenced
this pull request
May 8, 2024
…2504) * fix(inbound): invalid definitions are not stored for user convenience * fix polling connector test * address review suggestions fix test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces an additional mechanism for capturing errors related to invalid connector configuraitons that happen before creating inbound connector executables (for example, when multiple connectors that have different properties are combined using the same deduplication ID).
Instead of discarding such errors, they are now captured in an
InvalidInboundConnectorDetailsobject. TheInboundConnectorDetailsclass became a sealed interface. The new sealed hierarchy is needed because invalid inbound connector details won't have the same fields as the valid ones (e.g.propertieswill be missing, as they might be different for connector elements in an invalid group).Additionally, this PR changes the validation error message in the element templates that support deduplication. The reason behind this change is that the properties panel shows an error in the following format:
<property label> <error message>, so the new message fits more naturally.Related issues
closes https://github.com/camunda/team-connectors/issues/762