Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore app fails to inject backup store #10824

Closed
oleschoenburg opened this issue Oct 26, 2022 · 3 comments · Fixed by #10825
Closed

Restore app fails to inject backup store #10824

oleschoenburg opened this issue Oct 26, 2022 · 3 comments · Fixed by #10825
Assignees
@oleschoenburg
Labels
kind/bug Categorizes an issue or PR as a bug version:8.1.3 Marks an issue as being completely or in parts released in 8.1.3 version:8.2.0-alpha2 Marks an issue as being completely or in parts released in 8.2.0-alpha2 version:8.2.0 Marks an issue as being completely or in parts released in 8.2.0

Comments

@oleschoenburg
Copy link
Member

Starting the restore app with all necessary configuration fails because Spring can't inject the backup store:

Error creating bean with name 'backupStore' defined in class path resource [io/camunda/zeebe/restore/BackupStoreComponent.class]:
Invalid destruction signature; nested exception is org.springframework.beans.factory.support.BeanDefinitionValidationException:
Could not find a destroy method named 'close' on bean with name 'backupStore'
@oleschoenburg oleschoenburg added the kind/bug Categorizes an issue or PR as a bug label Oct 26, 2022
@oleschoenburg oleschoenburg mentioned this issue Oct 26, 2022
Merged
zeebe-bors-camunda bot added a commit that referenced this issue Oct 27, 2022
@zeebe-bors-camunda @oleschoenburg
merge: #10825
924c2fa 
10825: Fix restore app startup and shutdown behavior r=oleschoenburg a=oleschoenburg

- fixes injection of backup store
- fixes missing shutdown of restore app
- fixes a confusing and noisy exception when restore fails within a docker container

closes #10824 

Co-authored-by: Ole Schönburg <ole.schoenburg@gmail.com>
zeebe-bors-camunda bot added a commit that referenced this issue Oct 27, 2022
@zeebe-bors-camunda @oleschoenburg
merge: #10825
7b142d2 
10825: Fix restore app startup and shutdown behavior r=oleschoenburg a=oleschoenburg

- fixes injection of backup store
- fixes missing shutdown of restore app
- fixes a confusing and noisy exception when restore fails within a docker container

closes #10824 

Co-authored-by: Ole Schönburg <ole.schoenburg@gmail.com>
zeebe-bors-camunda bot added a commit that referenced this issue Oct 27, 2022
@zeebe-bors-camunda @oleschoenburg
merge: #10825
9a9eaf4 
10825: Fix restore app startup and shutdown behavior r=oleschoenburg a=oleschoenburg

- fixes injection of backup store
- fixes missing shutdown of restore app
- fixes a confusing and noisy exception when restore fails within a docker container

closes #10824 

Co-authored-by: Ole Schönburg <ole.schoenburg@gmail.com>
zeebe-bors-camunda bot added a commit that referenced this issue Oct 27, 2022
@zeebe-bors-camunda @oleschoenburg
merge: #10825
2897135 
10825: Fix restore app startup and shutdown behavior r=oleschoenburg a=oleschoenburg

- fixes injection of backup store
- fixes missing shutdown of restore app
- fixes a confusing and noisy exception when restore fails within a docker container

closes #10824 

Co-authored-by: Ole Schönburg <ole.schoenburg@gmail.com>
zeebe-bors-camunda bot added a commit that referenced this issue Oct 27, 2022
@zeebe-bors-camunda @oleschoenburg
merge: #10825
6335ab6 
10825: Fix restore app startup and shutdown behavior r=oleschoenburg a=oleschoenburg

- fixes injection of backup store
- fixes missing shutdown of restore app
- fixes a confusing and noisy exception when restore fails within a docker container

closes #10824 

Co-authored-by: Ole Schönburg <ole.schoenburg@gmail.com>
zeebe-bors-camunda bot added a commit that referenced this issue Oct 27, 2022
@zeebe-bors-camunda @oleschoenburg @zambrovski
merge: #10825 #10831
3132414 
10825: Fix restore app startup and shutdown behavior r=oleschoenburg a=oleschoenburg

- fixes injection of backup store
- fixes missing shutdown of restore app
- fixes a confusing and noisy exception when restore fails within a docker container

closes #10824 

10831: Fix error on writing cache file in the Java client r=saig0 a=korthout

## Description

<!-- Please explain the changes you made here. -->

This is a recreation of #10642, as I had to rebase the branch.

## Related issues

<!-- Which issues are closed by this PR or are related -->

closes #10641



Co-authored-by: Ole Schönburg <ole.schoenburg@gmail.com>
Co-authored-by: Simon Zambrovski <simon.zambrovski@holisticon.de>
zeebe-bors-camunda bot added a commit that referenced this issue Oct 27, 2022
@zeebe-bors-camunda @oleschoenburg
merge: #10825
938df3e 
10825: Fix restore app startup and shutdown behavior r=oleschoenburg a=oleschoenburg

- fixes injection of backup store
- fixes missing shutdown of restore app
- fixes a confusing and noisy exception when restore fails within a docker container

closes #10824 

Co-authored-by: Ole Schönburg <ole.schoenburg@gmail.com>
@npepinpe
Copy link
Member

Is this fixed, or is anything still missing?

@oleschoenburg
Copy link
Member Author

As soon as #10825 is merged it's fixed

@npepinpe
Copy link
Member

Oh right, now I notice the X meaning it hasn't managed to merge 😅

@backport-action backport-action mentioned this issue Oct 28, 2022
Merged
zeebe-bors-camunda bot added a commit that referenced this issue Oct 28, 2022
@zeebe-bors-camunda @oleschoenburg
merge: #10843
8e14033 
10843: [Backport stable/8.1] Fix restore app startup and shutdown behavior r=oleschoenburg a=backport-action

# Description
Backport of #10825 to `stable/8.1`.

relates to #10824

Co-authored-by: Ole Schönburg <ole.schoenburg@gmail.com>
zeebe-bors-camunda bot added a commit that referenced this issue Oct 31, 2022
@zeebe-bors-camunda @oleschoenburg
merge: #10843
9e09096 
10843: [Backport stable/8.1] Fix restore app startup and shutdown behavior r=oleschoenburg a=backport-action

# Description
Backport of #10825 to `stable/8.1`.

relates to #10824

Co-authored-by: Ole Schönburg <ole.schoenburg@gmail.com>
@korthout korthout added the version:8.1.3 Marks an issue as being completely or in parts released in 8.1.3 label Nov 1, 2022
@remcowesterhoud remcowesterhoud added the version:8.2.0-alpha2 Marks an issue as being completely or in parts released in 8.2.0-alpha2 label Dec 6, 2022
@npepinpe npepinpe added the version:8.2.0 Marks an issue as being completely or in parts released in 8.2.0 label Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleschoenburg oleschoenburg

Labels
kind/bug Categorizes an issue or PR as a bug version:8.1.3 Marks an issue as being completely or in parts released in 8.1.3 version:8.2.0-alpha2 Marks an issue as being completely or in parts released in 8.2.0-alpha2 version:8.2.0 Marks an issue as being completely or in parts released in 8.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix restore app startup and shutdown behavior camunda/zeebe
4 participants
@npepinpe @oleschoenburg @korthout @remcowesterhoud