Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error on writing cache file in the Java client #10831

Merged
merged 2 commits into from Oct 27, 2022

Conversation

korthout
Copy link
Member

Description

This is a recreation of #10642, as I had to rebase the branch.

Related issues

closes #10641

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix to the last two minor versions. You can trigger a backport by assigning labels (e.g. backport stable/1.3) to the PR, in case that fails you need to create backports manually.

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually
  • The change has been verified by a QA run
  • The impact of the changes is verified by a benchmark

Documentation:

  • The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.)
  • New content is added to the release announcement
  • If the PR changes how BPMN processes are validated (e.g. support new BPMN element) then the Camunda modeling team should be informed to adjust the BPMN linting.

Please refer to our review guidelines.

@korthout korthout marked this pull request as ready for review October 27, 2022 09:48
@korthout korthout requested a review from saig0 October 27, 2022 09:48
@github-actions
Copy link
Contributor

Test Results

   948 files  ±    0     948 suites  ±0   1h 42m 21s ⏱️ + 1m 32s
7 733 tests +277  7 726 ✔️ +277  7 💤 ±0  0 ±0 
7 931 runs  +283  7 922 ✔️ +283  9 💤 ±0  0 ±0 

Results for commit bf01793. ± Comparison against base commit 2854485.

Copy link
Member

@saig0 saig0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@korthout 👍

bors merge

zeebe-bors-camunda bot added a commit that referenced this pull request Oct 27, 2022
10825: Fix restore app startup and shutdown behavior r=oleschoenburg a=oleschoenburg

- fixes injection of backup store
- fixes missing shutdown of restore app
- fixes a confusing and noisy exception when restore fails within a docker container

closes #10824 

10831: Fix error on writing cache file in the Java client r=saig0 a=korthout

## Description

<!-- Please explain the changes you made here. -->

This is a recreation of #10642, as I had to rebase the branch.

## Related issues

<!-- Which issues are closed by this PR or are related -->

closes #10641



Co-authored-by: Ole Schönburg <ole.schoenburg@gmail.com>
Co-authored-by: Simon Zambrovski <simon.zambrovski@holisticon.de>
@zeebe-bors-camunda
Copy link
Contributor

This PR was included in a batch that timed out, it will be automatically retried

@zeebe-bors-camunda
Copy link
Contributor

Build succeeded:

@zeebe-bors-camunda zeebe-bors-camunda bot merged commit 455ab31 into main Oct 27, 2022
@zeebe-bors-camunda zeebe-bors-camunda bot deleted the bugfix/10641_error_writing_cache_file branch October 27, 2022 16:18
@backport-action
Copy link
Collaborator

Successfully created backport PR #10836 for stable/8.0.

@backport-action
Copy link
Collaborator

Successfully created backport PR #10837 for stable/8.1.

zeebe-bors-camunda bot added a commit that referenced this pull request Oct 28, 2022
10837: [Backport stable/8.1] Fix error on writing cache file in the Java client r=saig0 a=backport-action

# Description
Backport of #10831 to `stable/8.1`.

relates to #10641

Co-authored-by: Simon Zambrovski <simon.zambrovski@holisticon.de>
zeebe-bors-camunda bot added a commit that referenced this pull request Oct 28, 2022
10836: [Backport stable/8.0] Fix error on writing cache file in the Java client r=saig0 a=backport-action

# Description
Backport of #10831 to `stable/8.0`.

relates to #10641

10839: [Backport stable/8.0] deps(maven): bump commons-text from 1.9 to 1.10.0 r=oleschoenburg a=menski

# Description
Backport of #10559 to `stable/8.0`.



Co-authored-by: Simon Zambrovski <simon.zambrovski@holisticon.de>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
zeebe-bors-camunda bot added a commit that referenced this pull request Oct 28, 2022
10837: [Backport stable/8.1] Fix error on writing cache file in the Java client r=saig0 a=backport-action

# Description
Backport of #10831 to `stable/8.1`.

relates to #10641

Co-authored-by: Simon Zambrovski <simon.zambrovski@holisticon.de>
@korthout korthout added release/8.0.8 version:8.1.3 Marks an issue as being completely or in parts released in 8.1.3 labels Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
version:8.1.3 Marks an issue as being completely or in parts released in 8.1.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error handling .camunda symbolic link
4 participants