Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the default un-overridable -Xms128m value #12416

Closed
aivinog1 opened this issue Apr 14, 2023 · 5 comments · Fixed by #12482
Closed

Remove the default un-overridable -Xms128m value #12416

aivinog1 opened this issue Apr 14, 2023 · 5 comments · Fixed by #12482
Assignees
Labels
kind/feature Categorizes an issue or PR as a feature, i.e. new behavior version:8.1.11 Marks an issue as being completely or in parts released in 8.1.11 version:8.2.3 Marks an issue as being completely or in parts released in 8.2.3 version:8.3.0-alpha1 Marks an issue as being completely or in parts released in 8.3.0-alpha1 version:8.3.0 Marks an issue as being completely or in parts released in 8.3.0

Comments

@aivinog1
Copy link
Contributor

Is your feature request related to a problem? Please describe.
It is hard to tune the JVM if I cannot override the default -Xms128m. I can't override it via JAVA_OPTS because it is used at first, and then goes explicit -Xms128m (and finally applied):

exec "$JAVACMD" $JAVA_OPTS -Xms128m -XX:+ExitOnOutOfMemoryError -Dfile.encoding=UTF-8...

Describe the solution you'd like
I would like to move all JVM options into the default Docker environment variable (JAVA_OPTS) so that users could override it easily (-Xms included).

Describe alternatives you've considered
We could just remove -Xms128m from the default options, but I can't predict the consequences.

Additional context
See the details here.
I would like to see the changes backported in 8.0, 8.1, 8.2 as well 🙂

@aivinog1 aivinog1 added the kind/feature Categorizes an issue or PR as a feature, i.e. new behavior label Apr 14, 2023
@remcowesterhoud
Copy link
Contributor

@megglos Do you know which team should be responsible for this one? I feel like this is more of a shared responsibility and I don't see it listed in the team split document.

@megglos
Copy link
Contributor

megglos commented Apr 18, 2023

this affects the dist module (which is shared? 😅 ), the script is generated via the appassembler-maven-plugin, which has a feature request for exactly this open since 2016 😅
mojohaus/appassembler#48

Just synced with @Zelldon on this, the best would probably be to remove the Xms flag from the plugin config and stick to jvm defaults
https://github.com/camunda/zeebe/blob/main/dist/pom.xml#L290

@remcowesterhoud
Copy link
Contributor

Oh right, I don't know how I missed that in the split document 🤦

I'll assign it to both our project in that case

@aivinog1
Copy link
Contributor Author

Hey @remcowesterhoud! If this is not occupied I could provide the PR to fix it:

Just synced with @Zelldon on this, the best would probably be to remove the Xms flag from the plugin config and stick to jvm defaults

@remcowesterhoud
Copy link
Contributor

@aivinog1 Thanks! It's not occupied so go ahead. I'll assign the issue to you 👍

zeebe-bors-camunda bot added a commit that referenced this issue Apr 20, 2023
12468: [Backport 8.1]: skip unnecessary blacklist check r=megglos a=Zelldon

## Description

Backport  #12306
<!-- Please explain the changes you made here. -->

## Related issues

<!-- Which issues are closed by this PR or are related -->

closes to #12041



12492: [Backport stable/8.1] feat(dist): Remove the `-xms` parameter r=remcowesterhoud a=backport-action

# Description
Backport of #12482 to `stable/8.1`.

relates to #12416

Co-authored-by: Meggle (Sebastian Bathke) <sebastian.bathke@camunda.com>
Co-authored-by: Alexey Vinogradov <vinogradov.a.i.93@gmail.com>
zeebe-bors-camunda bot added a commit that referenced this issue Apr 20, 2023
12491: [Backport stable/8.0] feat(dist): Remove the `-xms` parameter r=remcowesterhoud a=backport-action

# Description
Backport of #12482 to `stable/8.0`.

relates to #12416

Co-authored-by: Alexey Vinogradov <vinogradov.a.i.93@gmail.com>
zeebe-bors-camunda bot added a commit that referenced this issue Apr 20, 2023
12493: [Backport stable/8.2] feat(dist): Remove the `-xms` parameter r=remcowesterhoud a=backport-action

# Description
Backport of #12482 to `stable/8.2`.

relates to #12416

Co-authored-by: Alexey Vinogradov <vinogradov.a.i.93@gmail.com>
zeebe-bors-camunda bot added a commit that referenced this issue Apr 20, 2023
12492: [Backport stable/8.1] feat(dist): Remove the `-xms` parameter r=remcowesterhoud a=backport-action

# Description
Backport of #12482 to `stable/8.1`.

relates to #12416

Co-authored-by: Alexey Vinogradov <vinogradov.a.i.93@gmail.com>
zeebe-bors-camunda bot added a commit that referenced this issue Apr 20, 2023
12491: [Backport stable/8.0] feat(dist): Remove the `-xms` parameter r=remcowesterhoud a=backport-action

# Description
Backport of #12482 to `stable/8.0`.

relates to #12416

Co-authored-by: Alexey Vinogradov <vinogradov.a.i.93@gmail.com>
zeebe-bors-camunda bot added a commit that referenced this issue Apr 20, 2023
12492: [Backport stable/8.1] feat(dist): Remove the `-xms` parameter r=remcowesterhoud a=backport-action

# Description
Backport of #12482 to `stable/8.1`.

relates to #12416

Co-authored-by: Alexey Vinogradov <vinogradov.a.i.93@gmail.com>
@oleschoenburg oleschoenburg added version:8.2.3 Marks an issue as being completely or in parts released in 8.2.3 version:8.1.11 Marks an issue as being completely or in parts released in 8.1.11 labels Apr 21, 2023
@remcowesterhoud remcowesterhoud added version:8.3.0-alpha1 Marks an issue as being completely or in parts released in 8.3.0-alpha1 release/8.0.14 and removed version:8.3.0-alpha1 Marks an issue as being completely or in parts released in 8.3.0-alpha1 labels May 3, 2023
@megglos megglos added the version:8.3.0 Marks an issue as being completely or in parts released in 8.3.0 label Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes an issue or PR as a feature, i.e. new behavior version:8.1.11 Marks an issue as being completely or in parts released in 8.1.11 version:8.2.3 Marks an issue as being completely or in parts released in 8.2.3 version:8.3.0-alpha1 Marks an issue as being completely or in parts released in 8.3.0-alpha1 version:8.3.0 Marks an issue as being completely or in parts released in 8.3.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants