Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support sub process mapping in instance migration mode #17120

Closed
7 of 10 tasks
pedesen opened this issue Mar 26, 2024 · 0 comments · Fixed by #17121
Closed
7 of 10 tasks

Support sub process mapping in instance migration mode #17120

pedesen opened this issue Mar 26, 2024 · 0 comments · Fixed by #17121
Assignees
Labels
component/frontend Related to a frontend component component/operate Related to the Operate component/team kind/feature Categorizes an issue or PR as a feature, i.e. new behavior version:8.6.0-alpha1 Label that represents issues released on verions 8.6.0-alpha1

Comments

@pedesen
Copy link
Contributor

pedesen commented Mar 26, 2024

Description

Zeebe will support migration of process instances with sub processes.
Operate needs to enable users to map sub processes in instance migration mode.

User Story

Scenario: As an Operate user
    Given I am in instance migration mode (mapping step)
    When I select a sub processes as source element
    Then I can select a sub process as target element

Acceptance Criteria

  • Sub processes are available in the list of source elements
  • Sub processes are selectable in the source diagram
  • Source sub processes are mappable to target sub processes
  • Source sub processes can only be mapped to sub processes

Out of scope

Event sub processes and changing of scope are currently not supported in Zeebe (see #15923). In Operate this will not be respected, which means mapping event sub processes and changing of scope will be possible, and end in a rejection by Zeebe.

Definition of Ready - Checklist

  • The issue has a meaningful title, description, and testable acceptance criteria
  • If documentation needs to be updated, an issue is created in the camunda-docs repo, and the issue is added to our Operate project board.
  • If HELM charts need to be updated, an issue is created in the camunda-platform-heml repo, and the issue is added to our Operate project board.
  • Potential Security risks have been considered and added to the product-hub issue risk assessment
  • Cross-team dependencies have been considered

Optional:

  • Design input has been collected by the assignee

👉 Handover Dev to QA

  • Handy resources:
    BPMN/DMN models, plugins, scripts, REST API endpoints + example payload, etc :
  • Example projects:
  • Versions to validate:

Docker file : in case that it needed to be tested via docker share the version contain the fixed along with version of other services .

  • Release version ( in which version this fixed/feature will be released)

📗 Link to the test case

@pedesen pedesen added kind/feature Categorizes an issue or PR as a feature, i.e. new behavior component/operate Related to the Operate component/team component/frontend Related to a frontend component labels Mar 26, 2024
@pedesen pedesen self-assigned this Mar 26, 2024
github-merge-queue bot pushed a commit that referenced this issue Mar 28, 2024
## Description

Add support for mapping sub processes in instance migration mode in
Operate UI

- add sub processes to selectable flow nodes in
processXml.migration.source store
- add sub processes to selectable flow nodes in
processXml.migration.target store
- The constraint to allow mapping to the same element type already
exists
- Add tests to ensure constraints are respected

## Related issues

<!-- Which issues are closed by this PR or are related -->

closes #17120

<!-- Cut-off marker
_All lines under and including the cut-off marker will be removed from
the merge commit message_

## Definition of Ready

Please check the items that apply, before requesting a review.

You can find more details about these items in our wiki page about [Pull
Requests and Code
Reviews](https://github.com/camunda/zeebe/wiki/Pull-Requests-and-Code-Reviews).

* [ ] I've reviewed my own code
* [ ] I've written a clear changelist description
* [ ] I've narrowly scoped my changes
* [ ] I've separated structural from behavioural changes
-->

## Definition of Done

<!-- Please check the items that apply, before merging or (if possible)
before requesting a review. -->

_Not all items need to be done depending on the issue and the pull
request._

Code changes:
* [ ] The changes are backwards compatibility with previous versions
* [ ] If it fixes a bug then PRs are created to
[backport](https://github.com/camunda/zeebe/compare/stable/0.24...main?expand=1&template=backport_template.md&title=[Backport%200.24])
the fix to the last two minor versions. You can trigger a backport by
assigning labels (e.g. `backport stable/1.3`) to the PR, in case that
fails you need to create backports manually.

Testing:
* [x] There are unit/integration tests that verify all acceptance
criterias of the issue
* [ ] New tests are written to ensure backwards compatibility with
further versions
* [x] The behavior is tested manually
* [ ] The change has been verified by a QA run
* [ ] The impact of the changes is verified by a benchmark

Documentation:
* [ ] The documentation is updated (e.g. BPMN reference, configuration,
examples, get-started guides, etc.)
* [ ] If the PR changes how BPMN processes are validated (e.g. support
new BPMN element) then the Camunda modeling team should be informed to
adjust the BPMN linting.

Other teams:
If the change impacts another team an issue has been created for this
team, explaining what they need to do to support this change.
- [ ] [Tasklist](https://github.com/camunda/tasklist/issues)
- [ ] [Web Modeler](https://github.com/camunda/web-modeler/issues)
- [ ] [Desktop
Modeler](https://github.com/camunda/camunda-modeler/issues)
- [ ] [Optimize](https://github.com/camunda/camunda-optimize/issues)

Please refer to our [review
guidelines](https://github.com/camunda/zeebe/wiki/Pull-Requests-and-Code-Reviews#code-review-guidelines).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/frontend Related to a frontend component component/operate Related to the Operate component/team kind/feature Categorizes an issue or PR as a feature, i.e. new behavior version:8.6.0-alpha1 Label that represents issues released on verions 8.6.0-alpha1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants