Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define the job retries statically or as expression #3803

Closed
saig0 opened this issue Feb 7, 2020 · 2 comments · Fixed by #4126
Closed

Define the job retries statically or as expression #3803

saig0 opened this issue Feb 7, 2020 · 2 comments · Fixed by #4126
Assignees
@pihme
Labels
kind/feature Categorizes an issue or PR as a feature, i.e. new behavior scope/broker Marks an issue or PR to appear in the broker section of the changelog
Milestone
Advanced expressi...

Comments

@saig0
Copy link
Member

saig0 commented Feb 7, 2020

Is your feature request related to a problem? Please describe.
For a service task, I can define the retries as a number or dynamically as an expression.

Describe the solution you'd like
Same as in #3792.
@saig0 saig0 added Status: Ready kind/feature Categorizes an issue or PR as a feature, i.e. new behavior scope/broker Marks an issue or PR to appear in the broker section of the changelog labels Feb 7, 2020
@saig0 saig0 added this to the Advanced expression supported milestone Feb 7, 2020
@pihme pihme self-assigned this Mar 20, 2020
@pihme
Copy link
Contributor

pihme commented Mar 20, 2020

@saig0 This would require a change to .ZeebeTaskDefinition. Is this ok?

@saig0
Copy link
Member Author

saig0 commented Mar 23, 2020

Yes 👍 You need to change the type from Integer to String (integerAttribute to stringAttribute) in order to support expressions.

@pihme pihme mentioned this issue Mar 25, 2020
Merged
zeebe-bors bot added a commit that referenced this issue Mar 26, 2020
@zeebe-bors @pihme
Merge #4126
79ca231 
4126: 3803 job retries feel expression r=pihme a=pihme

## Description

Added FEEL expressions for job retries

## Related issues

closes #3803

#

Co-authored-by: pihme <pihme@users.noreply.github.com>
@zeebe-bors zeebe-bors bot closed this as completed in 0b7554d Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pihme pihme

Labels
kind/feature Categorizes an issue or PR as a feature, i.e. new behavior scope/broker Marks an issue or PR to appear in the broker section of the changelog
Projects
None yet
Milestone
Advanced expression supported
Development

Successfully merging a pull request may close this issue.

3803 job retries feel expression camunda/zeebe
4 participants
@oleschoenburg @saig0 @pihme @KerstinHebel