Remove obsolete zbench folder #9066
Assignees
Labels
kind/toil
Categorizes an issue or PR as general maintenance, i.e. cleanup, refactoring, etc.
version:8.1.0-alpha1
Marks an issue as being completely or in parts released in 8.1.0-alpha1
version:8.1.0
Marks an issue as being completely or in parts released in 8.1.0
Comments
pihme
added
the
kind/toil
|
As it's just deleting stuff, let's go ahead and do it in the near future. |
10 tasks
zeebe-bors-camunda bot
added a commit
that referenced
this issue
Apr 7, 2022
9015: Replace protocol-util module with explicit mapping via forward-declarations r=npepinpe a=npepinpe ## Description This PR drops the `protocol-util` module entirely, instead opting for a more explicit mapping done via a forward-declaration in the `ImmutableProtocol` annotation. The annotation now has a mandatory member, `builder`, which should be assigned to the builder class generated by the immutable protocol. This will allow classes to later find the correct builder class, enabling deserialization use cases. It could be further extended to also enable mapping by declaring the immutable class as well. Doing this means the type itself carries all the information it needs to be deserialized by `protocol-jackson`, which makes the shading use case much, much simpler. Operate now only has to shade the protocol itself, nothing else needs to be shaded (though they may still want to shade the deserialization module to be safe, as shading is there for major versions). This PR also marks the generated types with two marker annotations: `ImmutableProtocol.Type` and `ImmutableProtocol.Builder`. The generated types (`ImmutableRecord`, `ImmutableVariableRecordValue`, etc.) will be marked with `ImmutableProtocol.Type`, and their builders with `ImmutableProtocol.Builder`. Doing so allows us to more easily detect whether a type needs special deserialization configuration (e.g. ``@JsonIgnore(unknownProperties` = true)` for the types marked), and also lets the `ProtocolFactory` easily find the concrete, immutable types for the abstract protocol types (i.e. look for `ImmutableProtocol` annotated types, then look for their implementing classes annotated with `ImmutableProtocol.Type`). We can then move the `ValueTypeMapping` class into the protocol since it has no dependency other than the protocol. This allows us to get rid entirely of the `protocol-util` module, which was admittedly a very broad module by definition, and most likely would have become a shallow module over time. A few tests were added to compensate, mostly `ArchUnit` tests to ensure that the forward-declared builder builds the correct type, and again in the factory to ensure we can generate objects for all protocol types. 9068: chore(benchmark): remove obsolete files r=pihme a=pihme ## Description Removes obsolete files ## Related issues closes #9066 Co-authored-by: Nicolas Pepin-Perreault <nicolas.pepin-perreault@camunda.com> Co-authored-by: pihme <pihme@users.noreply.github.com>
deepthidevaki
added
the
version:8.1.0-alpha1
Zelldon
added
the
version:8.1.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
This folder is obsolete: https://github.com/camunda/zeebe/blob/180f95473987e6c439b4ac00294ab1be8281bdae/benchmarks/project/zbench
https://camunda.slack.com/archives/CSQ2E3BT4/p1649249014632819
The text was updated successfully, but these errors were encountered: