chore(benchmark): remove obsolete files #9068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors merge |
|
Build failed: |
|
bors merge |
|
Build failed: |
|
bors merge |
zeebe-bors-camunda bot
added a commit
that referenced
this pull request
Apr 7, 2022
9015: Replace protocol-util module with explicit mapping via forward-declarations r=npepinpe a=npepinpe ## Description This PR drops the `protocol-util` module entirely, instead opting for a more explicit mapping done via a forward-declaration in the `ImmutableProtocol` annotation. The annotation now has a mandatory member, `builder`, which should be assigned to the builder class generated by the immutable protocol. This will allow classes to later find the correct builder class, enabling deserialization use cases. It could be further extended to also enable mapping by declaring the immutable class as well. Doing this means the type itself carries all the information it needs to be deserialized by `protocol-jackson`, which makes the shading use case much, much simpler. Operate now only has to shade the protocol itself, nothing else needs to be shaded (though they may still want to shade the deserialization module to be safe, as shading is there for major versions). This PR also marks the generated types with two marker annotations: `ImmutableProtocol.Type` and `ImmutableProtocol.Builder`. The generated types (`ImmutableRecord`, `ImmutableVariableRecordValue`, etc.) will be marked with `ImmutableProtocol.Type`, and their builders with `ImmutableProtocol.Builder`. Doing so allows us to more easily detect whether a type needs special deserialization configuration (e.g. ``@JsonIgnore(unknownProperties` = true)` for the types marked), and also lets the `ProtocolFactory` easily find the concrete, immutable types for the abstract protocol types (i.e. look for `ImmutableProtocol` annotated types, then look for their implementing classes annotated with `ImmutableProtocol.Type`). We can then move the `ValueTypeMapping` class into the protocol since it has no dependency other than the protocol. This allows us to get rid entirely of the `protocol-util` module, which was admittedly a very broad module by definition, and most likely would have become a shallow module over time. A few tests were added to compensate, mostly `ArchUnit` tests to ensure that the forward-declared builder builds the correct type, and again in the factory to ensure we can generate objects for all protocol types. 9068: chore(benchmark): remove obsolete files r=pihme a=pihme ## Description Removes obsolete files ## Related issues closes #9066 Co-authored-by: Nicolas Pepin-Perreault <nicolas.pepin-perreault@camunda.com> Co-authored-by: pihme <pihme@users.noreply.github.com>
|
Build failed (retrying...): |
|
bors merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes obsolete files
Related issues
closes #9066
Definition of Done
Not all items need to be done depending on the issue and the pull request.
Code changes:
backport stable/1.3) to the PR, in case that fails you need to create backports manually.Testing:
Documentation: