[forwardport stable/8.3] Allow decision requirements in column family 49 #16420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test case was not surfacing a bug due to usage of a specific user-defined string as the decisionRequirementsId. This meant that the correct data did not trigger the false positive where it would be attempted to be moved. (cherry picked from commit 7bdbf0f)
Previously, this code tried to move the data if it did not match the processInstanceKeyByProcessDefinitionKey but actually it should move it when it does match that. another way to look at it, is that it should leave entries that match the decisionRequirementsIdAndVersion key should be left alone because they belong in this column family. Only entries that cannot be matched to the decisionRequirementsIdAndVersion should be moved. (cherry picked from commit 7f64ab4)
Adds another assertion to verify that the data that is not moved by the corrector is the entries that we expect to stay in the column family (i.e. the correct data) (cherry picked from commit 94a79c7)
korthout
changed the title
Zelldon
approved these changes
Feb 16, 2024
deepthidevaki
added
the
version:8.3.8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backports #16411 to
stable/8.3.I had to resolve a few conflicts manually, but nothing major. I did not need the two commits related to the
countmethod, as this already exists (and is used) on 8.3. The main changes are exactly the same.Related issues
closes #16406
Definition of Done
Not all items need to be done depending on the issue and the pull request.
Code changes:
backport stable/1.3) to the PR, in case that fails you need to create backports manually.Testing:
Documentation:
Other teams:
If the change impacts another team an issue has been created for this team, explaining what they need to do to support this change.
Please refer to our review guidelines.