1337906: Stack derived pool cleanup #1262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minicuts
force-pushed
the
fnguyen/1337906-master
branch
from
c90836f
to
0dbb613
Compare
|
@candlepin-pull-request-bot test this please |
|
@nguyenfilip why test the import scenario also with this PR? |
|
@vritant The problem manifested itself only in refresh pools code path. It seemed to me that import manifest is the best way to realistically trigger refresh pools in CP 2.0. |
In some code paths, it may be possible that deletion of entitlements might not succeed (DELETE statement is not issued to the database). The underlying issue here is with collection Pool.entitlements. Because this collection has cascade set to PERSIST, one must be very careful when deleting entitlement to also remove it from the collection. Otherwise, Hibernate will un-schedule the deletion.
minicuts
force-pushed
the
fnguyen/1337906-master
branch
from
0dbb613
to
e4750a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some code paths, it may be possible that deletion of entitlements
might not succeed (DELETE statement is not issued to the database).
The underlying issue here is with collection Pool.entitlements. Because
this collection has cascade set to PERSIST, one must be very careful
when deleting entitlement to also remove it from the collection.
Otherwise, Hibernate will un-schedule the deletion.