Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert check for guest migration #1445

Merged
merged 1 commit into from
Jan 17, 2017
Merged

Revert check for guest migration #1445

merged 1 commit into from
Jan 17, 2017

Conversation

vritant
Copy link
Contributor

@vritant vritant commented Jan 16, 2017 •
edited
Loading

  • while we discuss guest migration, reverting the guest migration implementation to what is currently in 0.9.54.
  • this is a selective revert of this commit.

@vritant vritant force-pushed the vritant/migration-revert branch 2 times, most recently from 8be55a5 to 97d1359 Compare January 16, 2017 11:18
@vritant
Copy link
Contributor Author

vritant commented Jan 16, 2017

@candlepin-pull-request-bot test this please

@mstead mstead self-assigned this Jan 17, 2017
mstead
mstead suggested changes Jan 17, 2017
View reviewed changes
server/src/main/java/org/candlepin/resource/ConsumerResource.java
if (consumer == null) {
throw new NotFoundException(i18n.tr("Unit with ID ''{0}'' could not be found.", consumerUuid));
}
checkForGuestMigration(consumer);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verifyAndLookupConsumer will throw an exception if it is not found. The null check is not required.

@mstead mstead merged commit b886e2e into master Jan 17, 2017
@mstead mstead deleted the vritant/migration-revert branch January 17, 2017 18:07
@vritant vritant mentioned this pull request Feb 22, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mstead mstead mstead approved these changes

Assignees

@mstead mstead

Labels
ASAP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vritant @mstead @barnabycourt