Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Necessary features for client (Tt) #2

Open
2 tasks done
bmomberger-bitovi opened this issue Jul 8, 2021 · 3 comments
Open
2 tasks done

Necessary features for client (Tt) #2

bmomberger-bitovi opened this issue Jul 8, 2021 · 3 comments

Comments

@bmomberger-bitovi
Copy link
Collaborator

bmomberger-bitovi commented Jul 8, 2021

  • stache helpers are using can.isFunction() to see if a passed in value is a compute and should be called for its value -- computes are functions but report false to can.isFunction(). This may need to be made an exception.
  • getHelper in view/stache/helpers/core should allow a non-Scope as the scope argument (and wrap into a can.view.Scope)
@justinbmeyer
Copy link
Contributor

can-value migration

@bmomberger-bitovi
Copy link
Collaborator Author

bmomberger-bitovi commented Jul 12, 2021

  • Stache renderer called with no arguments currently causes an error when trying to can.assign values to the undefined variableScope._context. I think this is because Scope does not have a default context when instantiated with no arguments.
  • Control.proxy needs to take a string arg. (used by file upload components)
  • Navigating away from Trade Rates -> Tariff Rules in the primary menu causes an error in rules.js _destroyAllPageControllers -- listeners in mutate queue are already queued when controls are programmatically destroyed
    • same for navigating away from Trade Manager -> Consolidation
  • can.extend needs to support more than two arguments (search on consolidation planning throws error because params are created with can.extend({}, defaults, formParams)
    • $.extend and Object.assign both support variadic arguments, but can-assign does not.

@bmomberger-bitovi
Copy link
Collaborator Author

bmomberger-bitovi commented Jul 13, 2021

  • can.view with only one argument should return the renderer, not render to a frag.
  • drag targets in consolidation planning are not dragging -- this was due to jQuery events dispatching from jquery.datatables not being picked up by a can.Control
  • needs further investigation: consolidation in progress search results have null for all of the admin properties, and this is causing an error in the shipper getter in the consolidation model when clicking on a search result. See below.
    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants