Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can-compile doesn't work offline #30

Closed
ccummings opened this issue Jan 12, 2015 · 5 comments
Closed

can-compile doesn't work offline #30

ccummings opened this issue Jan 12, 2015 · 5 comments

Comments

@ccummings
Copy link
Contributor

jQuery and CanJS are included from external locations so if you are offline can-compile will not work. They are included here: https://github.com/daffl/can-compile/blob/master/lib/compile.js#L11

Maybe each library should be local?

@daffl
Copy link
Contributor

daffl commented Jan 13, 2015

It should but I didn't find a good way to get the different versions. They could ship with the repository I guess. Or through bower installing maybe (but we don't want to install every available version)?

@ccummings
Copy link
Contributor Author

What about adding an option that configures the path to where CanJS is? That let's can-compile just use the version the user has installed and doesn't make any assumptions about the rest of the stack (bower, npm, jspm, etc).

Depending on version, some template engines are in core vs. plugins which isn't accounted for now.

@daffl
Copy link
Contributor

daffl commented Feb 19, 2015

That could work but what do we do if someone uses a module loader?

@ccummings
Copy link
Contributor Author

Once CanJS 2.2.0 is on npm we could add it as a dependency and load it from node_modules.

@daffl
Copy link
Contributor

daffl commented Apr 13, 2015

I think this can be considered closed via #36.

@daffl daffl closed this as completed Apr 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants