#157 adds warning when global fixture is called #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cherifGsoul
reviewed
Apr 5, 2019
fixture.js
Outdated
| // window.fixture = fixture; | ||
|
|
||
| window.fixture = function(){ | ||
| debugger |
There was a problem hiding this comment.
You forget debugger statement.
cherifGsoul
reviewed
Apr 5, 2019
test/fixture_test.js
Outdated
|
|
||
|
|
||
| testHelpers.dev.devOnlyTest("window.fixture warns when called", function() { | ||
| debugger |
There was a problem hiding this comment.
Another debugger statement here.
cherifGsoul
reviewed
Apr 5, 2019
fixture.js
Outdated
| @@ -67,7 +68,14 @@ canReflect.assignMap(fixture, { | |||
| }); | |||
|
|
|||
| if(typeof window !== "undefined" && typeof require.resolve !== "function") { | |||
| window.fixture = fixture; | |||
| // window.fixture = fixture; | |||
cherifGsoul
requested changes
Apr 5, 2019
- Removed debugger statements - Swapped fixture to come before steal clone test #165 (review)
chasenlehara
approved these changes
Apr 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For issue #157 adds warning for when global window fixture. But current test not currently running likely due to some other test failing. The test currently added works in isolation but when ran amongst other test it fails.