Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixture is added to the window #157

Open
justinbmeyer opened this issue Oct 23, 2018 · 2 comments
Open

fixture is added to the window #157

justinbmeyer opened this issue Oct 23, 2018 · 2 comments

Comments

@justinbmeyer
Copy link
Contributor

https://codepen.io/justinbmeyer/pen/gBBObr?editors=1010

if you remove fixture from being imported, the example still works.

@matthewp
Copy link
Contributor

window.fixture = fixture;
is where this happens. I don't recall the historical reason for adding it. So I'm not sure if it's a breaking change to remove it or not.

@justinbmeyer
Copy link
Contributor Author

It's almost certainly added to make fixture easy to use without the rest of CanJS. We should probably add a function that warns and calls fixture and then remove in the next Major release.

Amechi101 pushed a commit that referenced this issue May 1, 2019
#157 adds warning when global fixture is called
Amechi101 pushed a commit that referenced this issue May 1, 2019
Merged changes to master for #157 issue: adds warning when global fixture is called

Merged changes to master for #229 issue: ix the deprecated group’s name in the docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants