Add is-node & fix is-browser-window not to check for SimpleDOM #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds [is-node from can-util](https://github.com/canjs/can-util/tree/7e8669a666072dcbdcc34402b640a67d38ea5784/js/is-node) and changes is-browser-window to use `is-node` instead of checking for SimpleDOM’s presence. This change was made because in 4.0, [this check](https://github.com/canjs/can-util/blob/7e8669a666072dcbdcc34402b640a67d38ea5784/dom/events/events.js#L81) was returning false when run in the main production build of CanJS (where can-simple-dom is also packaged).
justinbmeyer
reviewed
Dec 1, 2017
| return typeof window !== "undefined" && | ||
| typeof document !== "undefined" && typeof SimpleDOM === "undefined"; | ||
| typeof document !== "undefined" && | ||
| isNode === false; |
There was a problem hiding this comment.
the isNode I'm not 100% sure on long-term. I think NWJS should be considered a browser window. I'm not sure how we can sniff this out, but isNode ==== false is fine for now. We'll need something later.
There was a problem hiding this comment.
done-autorender has a change for when running in nwjs. I agree though, using clientWidth or something would be a better solution long-term.
There was a problem hiding this comment.
Opened an issue to fix this long-term: #36
|
I realized that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds is-node from can-util and changes is-browser-window to use
is-nodeinstead of checking for SimpleDOM’s presence.This change was made because in 4.0, this check was returning false when run in the main production build of CanJS (where can-simple-dom is also packaged).