Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reevaluate how we determine is-browser-window #36

Open
chasenlehara opened this issue Dec 1, 2017 · 1 comment
Open

Reevaluate how we determine is-browser-window #36

chasenlehara opened this issue Dec 1, 2017 · 1 comment

Comments

@chasenlehara
Copy link
Member

From @justinbmeyer:

the isNode I'm not 100% sure on long-term. I think NWJS should be considered a browser window. I'm not sure how we can sniff this out, but isNode ==== false is fine for now. We'll need something later.

#35 (review)
@chasenlehara chasenlehara mentioned this issue Dec 1, 2017
Merged
@frank-dspeed
Copy link
Contributor

and this issue can be closed @chasenlehara

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@frank-dspeed @chasenlehara