Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add is-node & fix is-browser-window not to check for SimpleDOM #35

Merged
merged 2 commits into from
Dec 1, 2017
Merged

Add is-node & fix is-browser-window not to check for SimpleDOM #35

merged 2 commits into from
Dec 1, 2017

Commits on Dec 1, 2017

  1. Add is-node & fix is-browser-window not to check for SimpleDOM 

    This adds [is-node from can-util](https://github.com/canjs/can-util/tree/7e8669a666072dcbdcc34402b640a67d38ea5784/js/is-node) and changes is-browser-window to use `is-node` instead of checking for SimpleDOM’s presence.

This change was made because in 4.0, [this check](https://github.com/canjs/can-util/blob/7e8669a666072dcbdcc34402b640a67d38ea5784/dom/events/events.js#L81) was returning false when run in the main production build of CanJS (where can-simple-dom is also packaged).
    @chasenlehara
    chasenlehara committed Dec 1, 2017
    Configuration menu
    Copy the full SHA
    a16c16f View commit details
    Browse the repository at this point in the history

  2. Make sure is-node is defined before is-browser-window gets its value

    @chasenlehara
    chasenlehara committed Dec 1, 2017
    Configuration menu
    Copy the full SHA
    561c1e9 View commit details
    Browse the repository at this point in the history