Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Double rendering canjs component on initial load #23

Closed
christopherjbaker opened this issue Nov 12, 2018 · 0 comments
Closed

Double rendering canjs component on initial load #23

christopherjbaker opened this issue Nov 12, 2018 · 0 comments
Assignees
@ivospinheiro
Labels
bug

Comments

@christopherjbaker
Copy link
Contributor

At present, the React component renders the custom dom element as <foo-component />, then assigns the props to the already existing viewmodel. This has the effect of causing a double render at mount time, with the first render having no props.
@christopherjbaker christopherjbaker mentioned this issue Nov 12, 2018
Merged
ivospinheiro added a commit that referenced this issue Jan 9, 2019
@ivospinheiro
Fix #23 - Render canjs component only once on initial load
818482f 
Override can-view-callbacks renderComponent function to when element
auto-mount is false the component isn't auto mounted
@ivospinheiro ivospinheiro self-assigned this Jan 9, 2019
@ivospinheiro ivospinheiro mentioned this issue Jan 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ivospinheiro ivospinheiro

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@christopherjbaker @ivospinheiro