-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for CanJS 4 #22
Conversation
using ReactTestUtils - on createComponent ref callback get the component viewModel from the element using `can-symbol` `can.viewModel` an assign the react props to viewModel
using ReactTestUtils - on createComponent ref callback get the component viewModel from the element using `can-symbol` `can.viewModel` an assign the react props to viewModel
using ReactTestUtils - on createComponent ref callback get the component viewModel from the element using `can-symbol` `can.viewModel` an assign the react props to viewModel
using ReactTestUtils - on createComponent ref callback get the component viewModel from the element using `can-symbol` `can.viewModel` an assign the react props to viewModel
using ReactTestUtils - on createComponent ref callback get the component viewModel from the element using `can-symbol` `can.viewModel` an assign the react props to viewModel
@ivospinheiro I brought your code into a local branch so we can continue iterating on it. Your fix is what was needed, though I altered it to use can-reflect.assign instead of just At present, this will mount the component without any data (causing the initial render), then immediately assign the props to the VM, causing a second render with the correct data. I am still looking into |
93bcd9a
to
f99eee1
Compare
@christopherjbaker I've noticed that but I had no idea how to fix that. What I understood was that the component was being rendered but with no initial data. Is there any way to set set the bound properties when creating the element on |
Hi @christopherjbaker and @justinbmeyer. |
@christopherjbaker many thanks. |
Glad to be of service! |
resolves #20, continues #21