-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Naming the URL observable #176
Comments
@matthewp How would we handle development.html? I think mapping |
So the import { route, RoutePushstate, Bind } from "can";
import AppViewModel from "./app";
var routeBinding = new Bind({
child: new AppViewModel(),
parent: new RoutePushstate()
});
route.register("{page}");
routeBinding.start(); |
I guess this would be prohibitive since there's a lot more to the binding ( Line 230 in b5faeb4
|
@phillipskevin We want to move towards more directly using can-bind in a way that users could do the same themselves if needed. So removing the internal stuff like that is something we can do in the future. This particular change is a bridge between the old API (removing backwards compatible, except for can-route-pushstate), and the new one that will work more like that, hopefully. |
I guess we're going to stick with |
can-route 4.2.0 will introduce a new way to set what type of URL observable will be used. As the default, it is can-route-hash, but can-route-pushstate users will need to set it.
This is similar to how you set
route.data
to be your ViewModel. The flow will be something like:What is a good name for this property? Is urlData ok or something else?
cc @phillipskevin @chasenlehara @justinbmeyer
The text was updated successfully, but these errors were encountered: