Merge pull request #341 from schovi/can-sub-remove-fix

can.sub fix remove param. Allow only to remove properties + tests
canjs · Apr 16, 2013 · e7e335b · e7e335b
2 parents ff1d361 + 3367817
commit e7e335b
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/util/string/string.js b/util/string/string.js
@@ -171,7 +171,7 @@ steal('can/util',function(can) {
 				obs.push( str.replace( strReplacer, function( whole, inside ) {
 
 					// Convert inside to type.
-					var ob = can.getObject( inside, data, remove === undefined? remove : !remove );
+          var ob = can.getObject( inside, data, remove === true ? false : undefined );
 
 					if(ob === undefined) {
 						obs = null;

diff --git a/util/string/string_test.js b/util/string/string_test.js
@@ -27,6 +27,14 @@ test("String.underscore", function(){
 	equals(can.underscore("Foo.Bar.ZarDar"),"foo.bar.zar_dar")
 });
 
+test("can.sub remove", function(){
+  var obj = {a: 'a'}
+  equals(can.sub("{a}", obj, false), "a");
+  deepEqual(obj, {a: 'a'});
+
+  equals(can.sub("{a}", obj, true), "a");
+  deepEqual(obj, {});
+});
 
 test("can.getObject", function(){
 	var obj = can.getObject("foo", [{a: 1}, {foo: 'bar'}]);