New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List#sort does not cause {{#each key}} to update #1566

Closed
asavoy opened this Issue Mar 30, 2015 · 1 comment

Comments

Projects
None yet
4 participants
@asavoy
Contributor

asavoy commented Mar 30, 2015

When using the can/list/sort plugin in CanJS 2.2.1.

See http://jsbin.com/cogafezomo/2/edit?html,js,output

It will update a list rendered with {{#key}} but not when rendered with {{#each key}}.

@akagomez

This comment has been minimized.

Show comment
Hide comment
@akagomez

akagomez Mar 30, 2015

Contributor

The reason this isn't working is because of additional text nodes in the template (whitespace, new lines, etc).

This will work with those removed.. http://jsbin.com/fomequfosa/1/edit?html,js,output

That said, this issue exposes others at the DOM manipulation layer of the Sort plugin.

@daffl and I will be taking a look later today.

Contributor

akagomez commented Mar 30, 2015

The reason this isn't working is because of additional text nodes in the template (whitespace, new lines, etc).

This will work with those removed.. http://jsbin.com/fomequfosa/1/edit?html,js,output

That said, this issue exposes others at the DOM manipulation layer of the Sort plugin.

@daffl and I will be taking a look later today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment