Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Highlighting is incorrect in File Navigator guide #3631

Closed
phillipskevin opened this issue Oct 12, 2017 · 0 comments
Closed

Highlighting is incorrect in File Navigator guide #3631

phillipskevin opened this issue Oct 12, 2017 · 0 comments
Assignees
@chasenlehara
Labels
documentation

Comments

@phillipskevin
Copy link
Collaborator

phillipskevin commented Oct 12, 2017 •
edited
Loading

In the solution of https://canjs.com/doc/guides/recipes/file-navigator-simple.html#Makethedataobservable, the highlighting is incorrect:

image
@phillipskevin phillipskevin changed the title Highlighting is off in File Navigator guide Highlighting is incorrect in File Navigator guide Oct 12, 2017
@chasenlehara chasenlehara self-assigned this Oct 12, 2017
@chasenlehara chasenlehara mentioned this issue Oct 17, 2017
Merged
chasenlehara added a commit that referenced this issue Oct 17, 2017
@chasenlehara
Fix highlighting in File Navigator Guide
62bc240 
Also:

- Add JSFiddle links for the simple and advanced guides
- Show snippets from the full JS code in the advanced guide
- Fix some errors
- Always use https for JS Bin embeds
- Other minor cleanup

Fixes #3631
chasenlehara added a commit that referenced this issue Oct 17, 2017
@chasenlehara
Fix highlighting in File Navigator Guide
1ab9632 
Also:

- Add JSFiddle links for the simple and advanced guides
- Show snippets from the full JS code in the advanced guide
- Fix some errors
- Always use https for JS Bin embeds
- Other minor cleanup

Fixes #3631
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chasenlehara chasenlehara

Labels
documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@phillipskevin @chasenlehara