Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Observe#on #394

Closed
rxaviers opened this issue May 24, 2013 · 3 comments
Closed

Observe#on #394

rxaviers opened this issue May 24, 2013 · 3 comments
Milestone
2.0.0

Comments

@rxaviers
Copy link

Have you considered a .on() alias for .bind()?
@matthewp
Copy link
Contributor

To me on signifies that I'm working with an EventEmitter type of object, and that's not really what an Observe is. on("change", ... makes sense but does on("somePropertyName", ... ? Not sure.

@imjoshdean
Copy link
Contributor

Honestly, I don't see the harm in aliasing can.on/off for can.bind/unbind. Looking at on("change", ... vs on("somePropertyName", ... they are both listening for emitted events, just different names.

@ghost ghost assigned imjoshdean Sep 27, 2013
imjoshdean added a commit that referenced this issue Oct 3, 2013
@imjoshdean
Added aliases for on/off to bind/unbind, as well as added docs. Clsoes …
1bcabe2 
…#394
imjoshdean added a commit that referenced this issue Oct 9, 2013
@imjoshdean
Finish adding on/off alias for bind/unbind in observes/routes. Closes #…
baf0852 
…394.
@rxaviers
Copy link
Author

rxaviers commented Oct 9, 2013

👍 cool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
3 participants
@imjoshdean @matthewp @rxaviers