fixes map unbind bug

[DVSoftware]

Fixes a bug i encountered while unbinding events on a map. If there are no events bound on a map, it throws an error, see http://jsfiddle.net/4ZxcL/

[justinbmeyer]

So, I thought about this while writing this code. I've found that blowing things up when unbinding on events that were never bound useful for discovering errors in code.

Thoughts on this?

[daffl]

Maybe as a dev warning? Most DOM libraries don't error either when unbinding something that didn't have any events.

[DVSoftware]

We have a really large code base, and after upgrading CanJS to latest, we started facing this bug, and we currently are not in a position to refactor all of the code to make this upgrade. I agree with daffl, most of the libraries don't error, they just unbind if events are set, and it makes sense. For example, i want to unbind all change listeners regardless there are any.

[justinbmeyer]

I believe dojo and yui do.

Sent from my iPhone

On Jun 10, 2014, at 4:58 PM, David Luecke notifications@github.com wrote:

Maybe as a dev warning? Most DOM libraries don't error either when unbinding something that didn't have any events.

—
Reply to this email directly or view it on GitHub.

[justinbmeyer]

Just to make sure everyone knows this ... map.unbind('foo') does not unbind all 'foo' events.

Sent from my iPhone

On Jun 10, 2014, at 5:16 PM, DVSoftware notifications@github.com wrote:

We have a really large code base, and after upgrading CanJS to latest, we started facing this bug, and we currently are not in a position to refactor all of the code to make this upgrade. I agree with daffl, most of the libraries don't error, they just unbind if events are set, and it makes sense. For example, i want to unbind all change listeners regardless there are any.

—
Reply to this email directly or view it on GitHub.